May 2023

2 commits
Advance input pointer when LZ4 compressing data
17 May 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1472 of 3 reviewers saw the final version

The pointer update in compress_lz4.c and multichunk TAP tests match #147; only the DEFAULT_IO_BUFFER_SIZE comment in compress_io.h is reworded.

  • Michael Paquiersaw the final versionLLM analysis, 100% sureMichael confirmed that the fix resolved his corrupt-dump reproducer in #148 and endorsed the multichunk test in #151.
  • Tom Lanesaw an earlier versionLLM analysis, 85% sureTom reproduced corruption in the landed LZ4 implementation in #140 and narrowed it to directory format in #142, before the pointer fix was posted.
  • Tomas Vondrasaw the final versioncommittercommitted the patch
Null-terminate the output buffer of LZ4Stream_gets
17 May 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #1502 of 4 reviewers saw the final version

The compress_lz4.c changes exactly match the final null-termination patch in #150.

  • Alexander Lakhinsaw an earlier versionLLM analysis, 87% sureAlexander's Valgrind testing of the landed LZ4 implementation exposed the unterminated buffer and sscanf misuse in #132.
  • Andrew Dunstansaw an earlier versionLLM analysis, 95% sureAndrew reviewed #133 and proposed replacing memset with explicit trailing termination in #134, prompting a local implementation change.
  • Michael Paquiersaw the final versionLLM analysis, 97% sureMichael checked the callback contract in #139 and requested removing the inconsistent assertion, which was the final adjustment in #150.
  • Tomas Vondrasaw the final versioncommittercommitted the patch

Apr 2023

1 commit
Rework code defining default compression for dir/custom formats in pg_dump
27 Apr 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surewritten from the discussion, no matching patch0 of 2 reviewers saw the final version

The attached fixes only remove an empty preprocessor branch; this commit instead reorders default algorithm selection in pg_dump.c to parse one compression specification. Its message credits the discussion initiated in #78 and continued in #82.

  • Justin Pryzbysaw an earlier versionLLM analysis, 97% sureJustin identified the confusing default-compression branch and proposed inline simplification in #78, before the broader committed rewrite.
  • Georgios Kokolatossaw an earlier versionLLM analysis, 92% sureGeorgios reviewed the inline default-compression proposal and its warning-free-build implications in #82, and the commit explicitly credits that discussion.

Mar 2023

5 commits
pg_dump: Use only LZ4 frame format for compression
31 Mar 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1301 of 1 reviewer saw the final version

Implements the shared-state LZ4-frame conversion from #130, with comment cleanup and consistent fs-to-state variable renaming described in #131.

  • Tomas Vondrasaw the final versiontrailerTomas reviewed the frame conversion and naming in #126 and #128, then cleaned up and committed the final version in #131.
pg_dump: Fix gzip compression of empty data
29 Mar 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surelanded as postedfrom patchset #962 of 2 reviewers saw the final version

Matches #96 modulo rebasing the intervening buffer-constant cleanup to DEFAULT_IO_BUFFER_SIZE; the empty-large-object test is unchanged. Justin reposted Georgios's patch, and the commit credits both authors.

  • Georgios Kokolatossaw the final versiontrailerGeorgios explicitly endorsed the final empty-data fix and its regression test in #124.
  • Tomas Vondrasaw the final versiontrailerTomas reviewed initialization and helper naming in #88, examined the revised patch, and announced committing it in #129.
Unify buffer sizes in pg_dump compression API
23 Mar 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1202 of 2 reviewers saw the final version

Exactly matches the second component of #120, replacing compression-specific buffer constants with DEFAULT_IO_BUFFER_SIZE. Tomas posted the series, but its header credits Georgios.

  • Tomas Vondrasaw the final versiontrailerTomas reviewed the buffer-size cleanup, prepared its final commit description in #120, and committed it as announced in #122.
  • Justin Pryzbysaw the final versiontrailerJustin reviewed the final series and reported successfully adapting his zstd implementation to it in #121.
Minor comment improvements for compress_lz4
23 Mar 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1202 of 2 reviewers saw the final version

Exactly matches the third component of #120, containing only compress_lz4.c comment improvements; the other two components landed separately.

  • Georgios Kokolatossaw the final versiontrailerGeorgios reviewed Tomas's comment improvements in #109 and incorporated them into #113, after which only light wording changes followed.
  • Justin Pryzbysaw the final versiontrailerJustin reviewed the final cleanup series and proposed further API-comment clarifications in #121.
Improve type handling in pg_dump's compress file API
23 Mar 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1202 of 2 reviewers saw the final version

Takes the first component of #120, changing only a boolean initializer from 0 to false following Justin's review. Tomas forwarded Georgios's API type-handling patch.

  • Tomas Vondrasaw the final versiontrailerTomas expanded the original type audit in #106, reviewed the API revisions, and committed the final patch in #122.
  • Justin Pryzbysaw the final versiontrailerJustin caught the boolean initializer and tested adapting zstd to the final API in #121.

Mar 2023

2 commits
Improve wording in pg_dump compression docs
1 Mar 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #812 of 2 reviewers saw the final version

Selects documentation and comment hunks from the first two components of #81, with a small additional comma correction in pg_dump.sgml.

  • Georgios Kokolatossaw the final versionLLM analysis, 100% sureGeorgios explicitly approved the wording fixes and identified the remaining comma inconsistency in #83.
  • Tomas Vondrasaw the final versioncommittercommitted the patch
Fix condition in pg_dump TAP test
1 Mar 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 97% surepart of a posted patchsetlight changesfrom patchset #861 of 1 reviewer saw the final version

The latest pre-commit attachment containing the TAP-parenthesis correction is #86, which carries Justin's fix from #81. The commit selects that hunk and lightly rewords its adjacent comment.

  • Tomas Vondrasaw the final versioncommittercommitted the patch

Jan 2023

1 commit
Fix behavior with pg_restore -l and compressed dumps
27 Jan 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #572 of 2 reviewers saw the final version

The one-line pg_fatal-to-pg_log_warning change in pg_backup_archiver.c exactly matches #57; the later series contains additional changes. Although Michael sent the matching attachment, the commit explicitly credits Georgios as author.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureJustin reported the regression in #53 and explicitly accepted the attached restoration in #58.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Nov - Dec 2022

4 commits
Provide test coverage in pg_dump for default behaviors with compression
6 Dec 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #18

Takes the test prerequisite from #18, adding a directory-format command_like check, explanatory comments, and clearer test labels as described in #19.

Switch pg_dump to use compression specifications
2 Dec 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #131 of 1 reviewer saw the final version

Closely follows #13, but preserves numeric compression-level output in the TOC summary instead of the proposed algorithm name and expands documentation of the compression-detail grammar.

  • Michael Paquiersaw the final versiontrailerMichael reviewed and rewrote the prerequisite in #12, then reviewed and committed the corrected defaults from #13 as announced in #14.
Refactor code parsing compression option values (-Z/--compress)
30 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #9

Takes the shared-parser component of #9, which incorporates Michael's revision from #7, adding pg_basebackup grammar documentation and minor formatting. Michael explicitly identifies Georgios as the primary author in #10.

meson: Add some missing env settings for tests of pg_dump and pg_verifybackup
29 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #6

Takes the Meson test-environment prerequisite from #6, reformats its GZIP_PROGRAM setting, and adds analogous missing compression-tool settings for pg_verifybackup.

Credits across 15 commits

Author
Georgios Kokolatos11
Justin Pryzby2 LLM4
Michael Paquier3
Tomas Vondra1
Reviewer
Tomas Vondracommitter8
Justin Pryzby3
Georgios Kokolatos2
Michael Paquiercommitter2
Reported by
Justin Pryzby5
Alexander Lakhin2
Michael Paquier1
Committer
Tomas Vondra9
Michael Paquier6

N LLM means N of the credits come from LLM analysis, not from commit trailers.