Dec 2022

3 commits
Fix macro definitions in pgstatfuncs.c
10 Dec 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #201 of 1 reviewer saw the final version

Applying #20 to the commit's parent reproduces src/backend/utils/adt/pgstatfuncs.c exactly, removing extra semicolons and four terminal continuation backslashes. The commit credits Nathan Bossart and Michael Paquier, who confirmed an identical independently prepared fix in #21.

  • Tom Lanesaw the final versionLLM analysis, 99% sureIn #18, he reported empty-declaration warnings in the landed relation and database macros, checked pgindent compatibility, and proposed both corrections implemented by #20.
Generate pg_stat_get*() functions for databases using macros
7 Dec 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #112 of 2 reviewers saw the final version

Compared with #11, the committed files differ only by alphabetizing the generated INT64 and FLOAT8 accessor groups in src/backend/utils/adt/pgstatfuncs.c, as Nathan requested in #12. All field renames and accessor logic match.

  • Nathan Bossartsaw the final versiontrailerIn #12, he said the patch looked good and requested alphabetizing the functions, which was the only change before commitment.
  • Bertrand Drouvotsaw the final versiontrailerIn #13, he considered retaining the n_ field prefix through token concatenation but endorsed the proposed renaming for consistency and said the patch looked good.
Generate pg_stat_get*() functions for tables using macros
6 Dec 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #52 of 2 reviewers saw the final version

Applying #5 to the commit's parent reproduces all five committed files exactly, including the relation accessor macros and corresponding field renames. Michael confirmed applying the relation patch in #11.

  • Nathan Bossartsaw the final versiontrailerHe requested the fixed prefix in #2, supplied editorial improvements in #4, and accepted the final naming revision as ready for a committer in #6.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Michael Paquier2
Bertrand Drouvot1
Nathan Bossart1
Reviewer
Nathan Bossart2
Bertrand Drouvot1
Michael Paquiercommitter1
Reported by
buildfarm member wrasse1
Tom Lane1
Committer
Michael Paquier3