Nov 2022

1 commit
Improve indenting in _hash_pgaddtup
24 Nov 2022David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #72 of 3 reviewers saw the final version

The committed diff matches #7 in src/backend/access/hash/hashinsert.c except for adding an explicit (IndexTuple) cast to PageGetItem(page, itemid). David Rowley confirms pushing that version in #8, and the commit credits Ted Yu.

  • Daniel Gustafssonsaw an earlier versionLLM analysis, 97% sureIn #2, he reported that running pgindent preserved the original indentation, prompting a subsequent structural rewrite of the assertion.
  • Tom Lanesaw the final versionLLM analysis, 96% sureHe proposed splitting the assertion into statements in #3 and extracting an ItemId local in #6, after which only readability and cast fixes followed.
  • David Rowleysaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Ted Yu1
Reviewer
David Rowleycommitter1
Committer
David Rowley1