Jul 2023

2 commits
Document more assumptions of LWLock variable changes with WAL inserts
26 Jul 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #441 of 1 reviewer saw the final version

Commits the second patch of #44, with light wording changes to comments in xlog.c and lwlock.c, as confirmed in #51. The commit credits Bharath Rupireddy and Andres Freund; #42 explicitly adopts Andres's explanation from #41.

  • Michael Paquiersaw the final versiontrailerRequested public-API barrier documentation in #27, reviewed its wording in #34 and #43, and committed the lightly edited final version reported in #51.
Optimize WAL insertion lock acquisition and release with some atomics
25 Jul 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #443 of 3 reviewers saw the final version

Matches the first patch of #44 modulo whitespace in the WALInsertLock declaration, converting insertingAt and the LWLock variable APIs to atomics across three files. The documentation and no-waiters fast-path patches are excluded; #45 confirms this selective application.

  • Nathan Bossartsaw the final versiontrailerRaised ordering concerns in #6, reviewed the exchange-based implementation in #12, endorsed it in #14, and requested longer tests in #19; the committed atomic-conversion component subsequently received only light edits.
  • Andres Freundsaw the final versiontrailerProposed the atomic approach in #2, identified ordering requirements in #7, and reviewed the implementation and requested its split in #41, after which the committed component changed only in comments and formatting.
  • Michael Paquiersaw the final versiontrailerReviewed ordering and documentation, reported extensive benchmarks in #27 and #30, requested the final comment adjustment in #43, and confirmed committing the atomic conversion in #45.

Credits across 2 commits

Author
Bharath Rupireddy2
Andres Freund1
Reviewer
Michael Paquier2
Andres Freund1
Nathan Bossart1
Committer
Michael Paquier2