model-writtenrun 4918 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tom Lane proposed replacing gen_node_support.pl's hard-coded EquivalenceClass and EquivalenceMember pointer handling with explicit copy_as_scalar and equal_as_scalar field annotations, preserving the generated copy and equality code #1.
- Peter Eisentraut questioned whether this behavior belonged to the node type or individual fields #2; Tom defended field-level control, acknowledged the risk of missing annotations, and proposed checking that referenced node types actually support recursive copying and comparison #3.
- Tom submitted a separate patch checking copy, equality, read, and write support, distinguishing handmade read/write implementations from unavailable support #4.
- Peter endorsed those cross-checks because declarations could otherwise express unsupported operations #5.
- Tom committed the cross-check patch with additional array_size field-order validation as b6bd5def3a, then committed the original annotation patch with minor documentation edits as 4c689a69ee.
- In the final message, Tom explained that array-size fields must precede their arrays to prevent broken reading and potentially out-of-bounds comparisons, and confirmed that he had added the checks and pushed; both patches had landed #6.