Dec 2022

2 commits
Fix thinko introduced in 6b423ec67
4 Dec 2022David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The three hunks in src/backend/utils/adt/numutils.c replace tmp > (PG_INTNN_MAX / 10) with tmp > -(PG_INTNN_MIN / 10), exactly the correction Dean Rasheed proposed in #8. David Rowley confirmed pushing the fix in #9; no attached patchset contains this follow-up.

  • Dean Rasheedsaw the final versionLLM analysis, 100% sureDean identified the unsuitable overflow bound and supplied the replacement expression adopted by the fix in #8, before the commit.
Improve performance of pg_strtointNN functions
4 Dec 2022David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: Non-decimal integer literals (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1

The commit preserves the complete unsigned-accumulation implementation from #1 in src/backend/utils/adt/numutils.c, changing three bounds to equivalent decimal expressions, adding three comments, and revising explanatory text, consistent with the small adjustments announced in #7. The supplied verdict for thread #44684 explicitly attributes this decimal optimization to this thread, agreeing that its non-decimal patchsets are not the source; both the patch and commit credit David Rowley and Dean Rasheed as authors.

Credits across 2 commits

Author
David Rowley1
Dean Rasheed1
Reported by
Dean Rasheed1
Committer
David Rowley2