[PATCH] Add .idea to gitignore for JetBrains CLion

Started by Sayyid Ali Sajjad Rizaviabout 3 years ago5 messages
#1Sayyid Ali Sajjad Rizavi
sasrizavi@gmail.com

From 6d10dafdd7c7789eddd7fd72ca22dfde74febe23 Mon Sep 17 00:00:00 2001
From: Ali Sajjad <sasrizavi@gmail.com>
Date: Sun, 4 Dec 2022 06:03:11 -0800
Subject: [PATCH] Add .idea to gitignore for JetBrains CLion

---
.gitignore | 1 +
1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 1c0f3e5e35..7118b90f25 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,6 +31,7 @@ win32ver.rc
 *.exe
 lib*dll.def
 lib*.pc
+**/.idea

# Local excludes in root directory
/GNUmakefile
--
2.34.1

Probably I'm the first one building PostgreSQL on CLion.

#2Sayyid Ali Sajjad Rizavi
sasrizavi@gmail.com
In reply to: Sayyid Ali Sajjad Rizavi (#1)
Re: [PATCH] Add .idea to gitignore for JetBrains CLion

I searched the commit fest app and there's already someone who has made
this.

On Sun, Dec 4, 2022 at 7:28 AM Sayyid Ali Sajjad Rizavi <sasrizavi@gmail.com>
wrote:

Show quoted text

From 6d10dafdd7c7789eddd7fd72ca22dfde74febe23 Mon Sep 17 00:00:00 2001
From: Ali Sajjad <sasrizavi@gmail.com>
Date: Sun, 4 Dec 2022 06:03:11 -0800
Subject: [PATCH] Add .idea to gitignore for JetBrains CLion

---
.gitignore | 1 +
1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 1c0f3e5e35..7118b90f25 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,6 +31,7 @@ win32ver.rc
*.exe
lib*dll.def
lib*.pc
+**/.idea

# Local excludes in root directory
/GNUmakefile
--
2.34.1

Probably I'm the first one building PostgreSQL on CLion.

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Sayyid Ali Sajjad Rizavi (#1)
Re: [PATCH] Add .idea to gitignore for JetBrains CLion

Sayyid Ali Sajjad Rizavi <sasrizavi@gmail.com> writes:

+**/.idea

Our policy is that the in-tree .gitignore files should only hide
files that are build artifacts of standard build processes.
Something like this belongs in your personal ~/.gitexclude,
instead.

(BTW, perhaps we should remove the entries targeting ".sl"
extensions? AFAIK that was only for HP-UX, which is now
desupported.)

regards, tom lane

#4Daniel Gustafsson
daniel@yesql.se
In reply to: Tom Lane (#3)
Re: [PATCH] Add .idea to gitignore for JetBrains CLion

On 4 Dec 2022, at 16:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Sayyid Ali Sajjad Rizavi <sasrizavi@gmail.com> writes:

+**/.idea

Our policy is that the in-tree .gitignore files should only hide
files that are build artifacts of standard build processes.
Something like this belongs in your personal ~/.gitexclude,
instead.

Since this comes up every now and again, I wonder if it's worth documenting
this in our .gitignore along the lines of:

--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,7 @@
+# This contains ignores for build artifacts from standard builds,
+# auxiliary files from local workflows should be ignored locally
+# with $GIT_DIR/info/exclude
+

(BTW, perhaps we should remove the entries targeting ".sl"
extensions? AFAIK that was only for HP-UX, which is now
desupported.)

+1. Grepping through the .gitignores in the tree didn't reveal anything else
that seemed to have outlived its usefulness.

--
Daniel Gustafsson https://vmware.com/

#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Daniel Gustafsson (#4)
Re: [PATCH] Add .idea to gitignore for JetBrains CLion

Daniel Gustafsson <daniel@yesql.se> writes:

On 4 Dec 2022, at 16:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Our policy is that the in-tree .gitignore files should only hide
files that are build artifacts of standard build processes.
Something like this belongs in your personal ~/.gitexclude,
instead.

Since this comes up every now and again, I wonder if it's worth documenting
this in our .gitignore along the lines of:

Good idea.

(BTW, perhaps we should remove the entries targeting ".sl"
extensions? AFAIK that was only for HP-UX, which is now
desupported.)

+1. Grepping through the .gitignores in the tree didn't reveal anything else
that seemed to have outlived its usefulness.

I'll make it so. Thanks for checking.

regards, tom lane