Remove SHA256_HMAC_B from scram-common.h

Started by Michael Paquierover 3 years ago3 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

While doing some hackery on SCRAM, I have noticed $subject giving the
attached. I guess that this is not going to cause any objections, but
feel free to comment just in case.

Thanks,
--
Michael

Attachments:

scram-include.patchtext/x-diff; charset=us-asciiDownload+0-3
#2Jacob Champion
jacob.champion@enterprisedb.com
In reply to: Michael Paquier (#1)
Re: Remove SHA256_HMAC_B from scram-common.h

On Mon, Dec 12, 2022 at 8:57 PM Michael Paquier <michael@paquier.xyz> wrote:

While doing some hackery on SCRAM, I have noticed $subject giving the
attached. I guess that this is not going to cause any objections, but
feel free to comment just in case.

Yeah, no objection :D That cryptohash refactoring was quite nice.

--Jacob

#3Michael Paquier
michael@paquier.xyz
In reply to: Jacob Champion (#2)
Re: Remove SHA256_HMAC_B from scram-common.h

On Tue, Dec 13, 2022 at 09:27:50AM -0800, Jacob Champion wrote:

On Mon, Dec 12, 2022 at 8:57 PM Michael Paquier <michael@paquier.xyz> wrote:

While doing some hackery on SCRAM, I have noticed $subject giving the
attached. I guess that this is not going to cause any objections, but
feel free to comment just in case.

Yeah, no objection :D That cryptohash refactoring was quite nice.

Thanks. I have much more refactoring work coming up in this area, and
the cryptohash move is helping quite a lot in terms of error handling.
--
Michael