Feb 2023

3 commits
Remove unnecessary #ifdef USE_ICU and branch.
23 Feb 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surelanded as postedfrom patchset #212 of 2 reviewers saw the final version

Matches the complete USE_ICU cleanup patch in #21, rebased over the preceding hash-buffer revisions. Ignoring whitespace and unchanged moved statements, both remove the same four provider guards and fallback error branches in hashfunc.c and varchar.c.

  • Peter Eisentrautsaw the final versiontrailerReviewed the broader refactoring in #6, #18, and #20, then endorsed the final arrangement in #23.
  • Peter Geoghegansaw the final versiontrailerReviewed the refactoring containing this cleanup in #12 and followed up in #14; the extracted guard removal remained unchanged apart from rebasing.
Refactor to introduce pg_locale_deterministic().
23 Feb 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #212 of 2 reviewers saw the final version

The complete pg_locale_deterministic() patch in #21 matches the commit after ignoring whitespace and diff metadata. It adds the NULL-aware accessor and replaces direct deterministic checks across seven files.

  • Peter Eisentrautsaw the final versiontrailerRequested a separate pg_locale_deterministic() patch in #20 and endorsed the resulting arrangement in #23.
  • Peter Geoghegansaw the final versiontrailerSuggested inlining pg_locale_deterministic() in #12 and requested performance evidence in #14; the accessor subsequently landed with the same logic.
Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
23 Feb 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #211 of 2 reviewers saw the final version

Derives from the comparison/transformation patch in #21, with ICU length arguments changed to int32_t, redundant wrappers removed, and transformed lengths adjusted to exclude the terminating NUL. Corresponding buffer allocations and hash lengths preserve existing NUL-inclusive hashing, as explained in #24.

  • Peter Eisentrautsaw the final versiontrailerReviewed scope and API details in #6, #18, and #20, then endorsed the source patchset's arrangement in #23 while explicitly noting he had not reread everything.
  • Peter Geoghegansaw an earlier versiontrailerRequested merged comparison/transformation patches and caller-side tie-breaking in #12, followed up in #14, and did not review the later ICU length and hash-buffer revisions.

Credits across 3 commits

Author
Jeff DavisLLM3
Reviewer
Peter Eisentraut3
Peter Geoghegan3
Committer
Jeff Davis3

N LLM means N of the credits come from LLM analysis, not from commit trailers.