Feb 2023

1 commit
Change argument type of pq_sendbytes from char * to void *
14 Feb 2023Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #211 of 1 reviewer saw the final version

The commit and #21 have identical stable patch IDs, covering pqformat.c, pqformat.h and cast removals in array_userfuncs.c, uuid.c and varbit.c; Peter confirms the landing in #23.

  • Corey Huinkersaw the final versiontrailerCorey endorsed #21 and reported that make check-world passed in #22.

Dec 2022

2 commits
Use appendStringInfoString instead of appendBinaryStringInfo where possible
30 Dec 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #175 of 5 reviewers saw the final version

The commit has the same stable patch ID as the first patch in #17, containing all 21 literal-string replacements in src/backend/utils/adt/jsonpath.c and no jsonb.c changes.

  • Andres Freundsaw the final versionLLM analysis, 96% sureAndres identified the strlen overhead risk in JSONB output in #2, prompting the scope reduction in #17 while the committed JSONPath changes remained unchanged.
  • David Rowleysaw the final versionLLM analysis, 99% sureDavid measured the original cleanup's JSONB slowdown in #13 and discussed an alternative after the revised submission in #18, with no subsequent changes to the committed JSONPath patch.
  • Tom Lanesaw the final versionLLM analysis, 96% sureTom supported the premise that JSONPath output was not performance-critical in #7, and the reviewed JSONPath replacements survived unchanged in #17.
  • Andrew Dunstansaw the final versionLLM analysis, 98% sureAndrew supported converting JSONPath calls while retaining the five JSONB calls in #9, matching the scope adopted in #17.
  • Robert Haassaw the final versionLLM analysis, 90% sureRobert endorsed retaining the straightforward JSONB literal-length calls in #12, a scope change adopted in #17 without altering the retained JSONPath replacements.
Change argument of appendBinaryStringInfo from char * to void *
30 Dec 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #171 of 1 reviewer saw the final version

The commit has the same stable patch ID as the second patch in #17, changing both binary append APIs to const void * and removing casts in jsonpath.c and xid8funcs.c. Differences in jsonpath.c hunk locations are solely rebase context.

  • Andrew Dunstansaw the final versionLLM analysis, 99% sureAndrew explicitly endorsed the void * argument change in #9, and that patch remained unchanged through #17 and landing.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Corey Huinker1
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.