Mar 2026

5 commits
Make cast functions to type money error safe
30 Mar 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #751 of 1 reviewer saw the final version

The complete cash.c diff exactly matches the money-conversion member of #75, including numeric_mul_safe, numeric_int8_safe, and pg_mul_s64_overflow. This selects one unchanged member of the nine-patch series; cash_numeric remains outside the change.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Make cast function from circle to polygon error safe
30 Mar 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #751 of 3 reviewers saw the final version

Selects the circle-to-polygon member of #75, replacing the SQL wrapper with C code and updating pg_proc.dat. The committed helper returns POLYGON * instead of Datum, uses direct NULL returns, and includes a catalog-version bump.

  • Amul Sulno review foundtrailerHis visible geometry reviews concern earlier helpers, and no review of the SQL-to-C circle conversion first attached in #72 is shown.
  • Corey Huinkerno review foundtrailerHis approval in #65 predates the circle-to-polygon implementation introduced in #72, and no review of that new implementation is visible.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Make geometry cast functions error safe
29 Mar 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #751 of 3 reviewers saw the final version

Combines the float-error helpers, safe float arithmetic, point_dt, and geometry members of #75. Committer edits restore void returns for box_cn and poly_to_circle with explicit context checks, and include the previously deferred dtof changes.

  • Amul Sulsaw an earlier versiontrailerHe reviewed geometry error returns and helper duplication in #36, #44, #46, and #53, before the later float-helper redesign and committer changes.
  • Corey Huinkersaw an earlier versiontrailerHe tested the series in #37, discussed safe-call overhead in #58, and approved #64 in #65, before the final helper revisions.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Make cast functions from jsonb error safe
28 Mar 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #751 of 3 reviewers saw the final version

The jsonb.c diff exactly matches the JSONB member of #75, including the Datum-returning cannotCastJsonbValue and direct returns from its callers. It is an unchanged selected member of the larger series.

  • Amul Sulsaw an earlier versiontrailerHe explicitly reviewed cannotCastJsonbValue in #36, before #70 prompted changing its void-returning interface to Datum.
  • Corey Huinkersaw an earlier versiontrailerHis series testing and approval in #37, #58, and #65 preceded the JSONB helper and caller rewrite in #72.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Make many cast functions error safe
24 Mar 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #691 of 3 reviewers saw the final version

Combines the bytea, bit, character, numeric, network, and date/time prerequisite members of #69. As explained in #70, it excludes the xmlparse NO_XML_SUPPORT softening and dtof overflow/underflow changes, leaving the text, JSONB, geometry, and main feature patches outstanding.

  • Amul Sulsaw an earlier versiontrailerHe reviewed the character/XML error handling in #36, before the additional bytea/uuid case and the committer's decision to retain hard errors for unavailable XML support.
  • Corey Huinkersaw an earlier versiontrailerHe challenged cast-function special cases in #26, reviewed and tested the expanded series, and approved #64 in #65, before the final additions and omissions.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 5 commits

Author
jian he5
Reviewer
Peter Eisentrautcommitter5
Amul Sul4
Corey Huinker4
Committer
Peter Eisentraut5