Feb 2023

1 commit
Allow underscores in integer and numeric constants.
4 Feb 2023Dean Rasheedmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #71 of 4 reviewers saw the final version

The commit matches #7 apart from documentation edits in doc/src/sgml/syntax.sgml and replacing INT_MAX with PG_INT32_MAX in numeric.c's exponent bound. Its message credits Peter Eisentraut and Dean Rasheed, reflecting Peter's original patch #1 and Dean's revisions.

  • Tom Lanesaw an earlier versionLLM analysis, 93% sureRaised input-function performance, unwanted-input acceptance, and consistency concerns about the initial patch #2, before the parsing rework in #7.
  • Justin Pryzbysaw an earlier versionLLM analysis, 80% sureSupported restricting underscores to literals and identified input-validation and performance concerns using Python's analogous behavior #3, before the rework in #7.
  • Andrew Dunstansaw an earlier versionLLM analysis, 90% sureIdentified the confusion caused by accepting underscore-separated literals while rejecting their quoted equivalents #4, an argument Dean adopted in #5 before the rework in #7.
  • Dean Rasheedsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Peter EisentrautLLM1
Reviewer
Dean Rasheedcommitter1
Committer
Dean Rasheed1

N LLM means N of the credits come from LLM analysis, not from commit trailers.