Feb 2023

2 commits
Redesign archive modules
17 Feb 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #702 of 2 reviewers saw the final version

Matches the complete archive API redesign in #70, including constant callback tables, ArchiveModuleState, startup/shutdown callbacks, and archive/ directories. Final edits are wording, formatting, and adding ArchiveModuleState to src/tools/pgindent/typedefs.list.

  • Andres Freundsaw the final versiontrailerAndres shaped initialization and typed state, insisted on shutdown cleanup in #64, and reviewed the final versions in #69 and #71, after which only light edits remained.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Remove uses of AssertVariableIsOfType() obsoleted by f2b73c8
9 Feb 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #551 of 1 reviewer saw the final version

Exactly matches the standalone assertion-cleanup component of #55: eight deleted lines across basic_archive, test_decoding, shell_archive.c, and pgoutput.c. The other three archive redesign patches were not included.

  • Andres Freundsaw the final versioncommittercommitted the patch

Jan 2023

3 commits
Rename contrib module basic_archive to basic_wal_module
25 Jan 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #221 of 1 reviewer saw the final version

Takes the basic_archive-to-basic_wal_module rename component of #22, leaving the GUC helper, documentation restructuring, and restore_library feature uncommitted. Its documentation reference is applied to archive-modules.sgml because the proposed wal-modules.sgml restructuring had not landed.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Refactor code for restoring files via shell commands
18 Jan 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #181 of 2 reviewers saw the final version

Takes the shell-command consolidation and BuildRestoreCommand() removal from #18, leaving recovery modules pending. Michael retained the NULL-value checks in src/common/percentrepl.c that the attachment removed, explaining this decision in #19.

  • Andres Freundsaw an earlier versiontrailerAndres reviewed the original proposal in #2 and #4, before the subsequent BuildRestoreCommand() removal and local shell-command changes.
  • Michael Paquiersaw the final versiontrailerMichael requested removal of BuildRestoreCommand() in #17, reviewed and adjusted the result in #19, and committed the final patch.
Refactor code in charge of running shell-based recovery commands
16 Jan 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #141 of 2 reviewers saw the final version

Takes the shell_restore.c extraction component of #14, leaving the other two patches pending. Besides comments and formatting, Michael wrapped failure reporting in an rc != 0 check, fixing the successful-command logging bug described in #15.

  • Andres Freundsaw an earlier versiontrailerAndres reviewed the original proposal in #2 and #4, before the restartpoint helper extraction and final failure-reporting correction.
  • Michael Paquiersaw the final versiontrailerMichael reviewed the cutoff-filename interface and duplication in #11 and #13, then fixed the logging bug and committed the patch as reported in #15.

Credits across 5 commits

Author
Nathan Bossart5
Reviewer
Andres Freundcommitter4
Michael Paquiercommitter4
Committer
Michael Paquier4
Andres Freund1