model-writtenrun 4851 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed extracting variable-length datatype support from postgres.h into varatt.h, initially including it through fmgr.h to minimize changes for extensions #1.
- Tom Lane argued that fmgr.h was too widely included to provide the intended reduction in header dependencies, and Nikita Malakhov supported requiring explicit includes where needed #3 #4.
- Isaac Morland suggested toast.h and Andres Freund suggested toast_type.h, but Matthias van de Meent explained that variable-length attributes serve more than TOAST, and Tom Lane supported retaining varatt.h #2 #5 #6 #7.
- Peter supplied a two-patch revision that retained the extraction and replaced the fmgr.h dependency with explicit includes in 41 files; Tom endorsed that result and asked about cpluspluscheck and headerscheck, while Andrew Dunstan also said it looked good #8 #9 #10.
- Peter committed both patches together as d952373a98, omitting an unnecessary cube header include and updating a documentation example, then announced the landing #11.
- After the commit, Noah Misch predicted widespread extension breakage because SET_VARSIZE appeared in 74 PGXN distributions and requested a revert; Peter remained open to alternatives #12 #13.
- Robert Haas defended a straightforward include adjustment in a major release and highlighted easier frontend access to varlena definitions, while Tom argued that the limited number of consumers justified the split and expected compilation savings #14 #15 #16.
- Noah's build benchmark found no speed improvement, and he proposed including varatt.h from postgres.h to preserve compatibility; Robert remained unconvinced that these definitions deserved permanent inclusion in the main header #17 #18.
- Peter left the committed change in place but explicitly treated the compatibility question as a semi-open item; the thread ended without a revert or replacement patch #19.