May 2023

1 commit
Fix incorrect TAP test ordering
15 May 2023Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The change in src/bin/pg_amcheck/t/004_verify_heapam.pl exactly matches Peter Eisentraut's inline replacement of is() with a conditional BAIL_OUT in #37. No attached patchset contains this fix.

  • Andres Freundsaw the final versionLLM analysis, 98% sureIn #36, Andres proposed terminating on missing offsets instead of recording a test result, which Peter implemented in the inline fix #37.

Mar 2023

4 commits
pg_amcheck: Minor test speedups
11 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #321 of 1 reviewer saw the final version

The complete patch in #32 matches the commit's stable patch ID, including batched inserts, one VACUUM FREEZE and bulk row-offset retrieval in src/bin/pg_amcheck/t/004_verify_heapam.pl.

  • Mark Dilgersaw the final versiontrailerMark accepted the attached optimization and the ROWCOUNT variable change in #33.
amcheck: Fix FullTransactionIdFromXidAndCtx() for xids before epoch 0
11 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.3REL_14_STABLE14.8
LLM analysis, 100% surelanded as postedfrom patchset #301 of 1 reviewer saw the final version

The second patch in #30 exactly matches the commit's stable patch ID, including modulo-difference conversion in contrib/amcheck/verify_heapam.c and corrected past/future xid tests.

  • Mark Dilgersaw the final versiontrailerMark said the revised amcheck changes looked reasonable in #31.
amcheck: Fix ordering bug in update_cached_xid_range()
11 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.3REL_14_STABLE14.8
LLM analysis, 100% surelanded as postedfrom patchset #301 of 1 reviewer saw the final version

The first patch in #30 exactly matches the commit's stable patch ID: it initializes next_xid before computing oldest_fxid and adds two assertions in contrib/amcheck/verify_heapam.c.

  • Mark Dilgersaw the final versiontrailerMark confirmed the initialization bug in #16 and reviewed the final amcheck changes favorably in #31.
Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids
8 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.3REL_14_STABLE14.8REL_13_STABLE13.11+1 more
LLM analysis, 100% surelanded as postedfrom patchset #211 of 1 reviewer saw the final version

The complete first patch in #21 has the same stable patch ID as the commit, retaining the private TransactionIdRetreatSafely() helper in procarray.c. The alternative public-helper implementation in #26 was not used.

  • Matthias van de Meentsaw the final versiontrailerMatthias identified incorrect shared clamping in #17 and #19, then reviewed the revised helper in #22 and resolved his performance concerns in #24.

Credits across 5 commits

Author
Andres Freund3 LLM4
Reviewer
Mark Dilger3
Matthias van de Meent1
Reported by
Mihail Nikalayeu1
Committer
Andres Freund4
Peter Eisentraut1

N LLM means N of the credits come from LLM analysis, not from commit trailers.