Mar 2023

3 commits
Fix initdb's handling of min_wal_size and max_wal_size.
22 Mar 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Andres Freund reported the --wal-segsize regression in #17, and Tom Lane diagnosed it in #18. The commit changes setup_config() to emit active min_wal_size and max_wal_size assignments; neither attached patch contains this correction.

  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres supplied the failing initdb --wal-segsize 64 reproduction in #17, directly prompting the correction and earning explicit credit in the commit message.
Reduce memory leakage in initdb.
22 Mar 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The attached versions retain copying string-array helpers, whereas this commit makes replace_token() and replace_guc_value() modify arrays in place and improves freeing in src/bin/initdb/initdb.c. Tom describes this separately developed, valgrind-motivated cleanup in #16; no matching patch was attached.

Add "-c name=value" switch to initdb.
22 Mar 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #121 of 4 reviewers saw the final version

The commit preserves the implementation, documentation, and tests from #12, with small cleanup edits in src/bin/initdb/initdb.c: removing the redundant ctype.h include, simplifying port substitution, preserving the sample formatting for C locales, and relocating a free. The include and port changes follow Peter Eisentraut's review in #14 and Tom's response in #16.

  • Andres Freundsaw an earlier versionLLM analysis, 96% sureAndres examined override precedence during configuration probes and suggested a regression test in #2, before the persistence mechanism was reworked.
  • Peter Eisentrautsaw the final versionLLM analysis, 99% surePeter questioned the configuration-file destination and reported a bootstrap assertion in #4, then endorsed the revised patch and proposed adopted cleanup changes in #14.
  • Isaac Morlandsaw an earlier versionLLM analysis, 95% sureIsaac argued in #5 that permanent initdb settings belong in postgresql.conf, a design change implemented by the subsequent rework.
  • Robert Haassaw an earlier versionLLM analysis, 97% sureRobert proposed the name-based replace_guc_value() editor and preservation of comment alignment in #8, which Tom implemented in the revised patch.

Credits across 3 commits

Author
Tom LaneLLM1
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.