Assert fcinfo has enough args before allowing parameter access (was: Re: generate_series for timestamptz and time zone problem)
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t47349psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 10:59 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t47349_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t47349_1 && git checkout t47349_1Patchset v1 (message #1) is on t47349_1
On Mon, Jan 30, 2023 at 11:50 PM Gurjeet Singh <gurjeet@singh.im> wrote:
It was the classical case of out-of-bounds access.
This mistake would've been caught early if there were assertions
preventing access beyond the number of arguments passed to the
function. I'll send the assert_enough_args.patch, that adds these
checks, in a separate thread to avoid potentially confusing cfbot.
Please see attached the patch to that ensures we don't accidentally
access more parameters than that are passed to a SQL callable
function.
Best regards,
Gurjeet
http://Gurje.et
Gurjeet Singh <gurjeet@singh.im> writes:
Please see attached the patch to that ensures we don't accidentally
access more parameters than that are passed to a SQL callable
function.
I'm unexcited by that. It'd add a pretty substantial amount
of code to catch an error that hardly anyone ever makes.
regards, tom lane