Apr 2025

4 commits
Fix performance issue in deadlock-parallel isolation test.
9 Apr 2025Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The timeout investigation in #48 led to replacing non-inlineable SQL lock wrappers with internal-language aliases and inlineable wrappers in src/test/isolation/specs/deadlock-parallel.spec. Tom identifies the committed solution in #49; no attachment contains this fix.

functions.c: copy trees from source_list before parse analysis etc.
4 Apr 2025Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Alexander Lakhin's repeated-call reproducer exposed corruption after parse-analysis failure #45, with clarification in #47. The commit adds copyObject() for both source-tree forms in prepare_next_query(); this fix is absent from the attached series.

  • Alexander Lakhinsaw the final versionLLM analysis, 94% sureTested the landed form of #40, reported the repeated-call invalid read under Valgrind #45, and confirmed that the initial error was intentional #47.
Fix oversight in commit 0dca5d68d.
3 Apr 2025Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Alexander Lakhin reported an assertion failure for an empty polymorphic SQL function #43, and Tom promised a fix #44. The commit adds the missing non-VOID empty-body check in sql_compile_callback() and regression tests; no attached patch contains it.

  • Alexander Lakhinsaw the final versionLLM analysis, 94% sureTested the landed form of #40 and supplied the empty-body assertion reproducer that directly prompted this fix #43.
Change SQL-language functions to use the plan cache.
2 Apr 2025Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #400 of 1 reviewer saw the final version

All seven patches in #40 apply to the commit's parent and reproduce the committed changes except routine/member ordering and comments in functions.c, include ordering in funccache.c, and removal of a speculative comment in pl_comp.c. The commit credits Alexander Pyhalov as author and Tom Lane as co-author, matching the cosmetic-only landing announcement #41.

  • Pavel Stehulesaw an earlier versiontrailerBenchmarked successive implementations, reviewed error context, and reported passing tests for #36 in #37, but the substantive delayed-analysis change in #40 followed his last review.

Credits across 4 commits

Author
Tom Lane2
Alexander Pyhalov1
Reviewer
Pavel Stehule1
Reported by
Alexander Lakhin2
Co author
Tom Lane1
Committer
Tom Lane4