Mar - Apr 2023

11 commits
Fix MSVC warning introduced in ea1db8ae70.
4 Apr 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Thomas Munro reported MSVC's missing-return warning in #42. The commit adds return NULL after fatal errors in pg_locale.c and initdb.c; neither addition appears in an attached patch.

  • Thomas Munrosaw the final versionLLM analysis, 99% sureReported the MSVC C4715 warning from the landed version of #40 in #42, prompting this fix.
Canonicalize ICU locale names to language tags.
4 Apr 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #401 of 1 reviewer saw the final version

The changed lines across all ten files match #40 after whitespace normalization. The commit expands the explanatory commit message but preserves the submitted implementation, documentation, and tests.

  • Peter Eisentrautsaw the final versiontrailerRaised compatibility and design concerns, requested notice and documentation changes in #38, and explicitly approved #40 in #41.
Validate ICU locales.
28 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: ICU 54 and earlier are too dangerous
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #350 of 1 reviewer saw the final version

Lands the validation component of #35, with USE_ICU handling centralized, additional diagnostic hints, and validation during binary upgrade capped at WARNING instead of skipped. Jeff explains the upgrade-policy change in #37.

  • Peter Eisentrautsaw an earlier versiontrailerProposed an error-level setting in #34 and reviewed #35 in #36, before the final upgrade-warning policy and local validation changes were implemented.
initdb: emit message when using default ICU locale.
28 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #351 of 1 reviewer saw the final version

Exactly matches the three added lines of #35's initdb default-locale-message component. The other four components of that submission are outside this commit.

  • Peter Eisentrautsaw the final versiontrailerAsked how to exercise the message in #34 and explicitly approved its revised component in #36.
initdb: replace check_icu_locale() with default_icu_locale().
28 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #351 of 1 reviewer saw the final version

Lands #35's default_icu_locale() extraction in src/bin/initdb/initdb.c. The final version keeps USE_ICU handling inside the helper, as requested in #36, without changing the proposed locale-selection algorithm.

  • Peter Eisentrautsaw the final versiontrailerRequested moving default-locale assignment to setlocales() in #34 and approved the revised extraction subject to the implemented conditional-compilation adjustment in #36.
Fix error inconsistency in older ICU versions.
28 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #350 of 1 reviewer saw the final version

Lands the error-consistency component of #35, preserving the original locale string and moving attribute-error handling into pg_ucol_open(). Unlike the attachment, a failed uloc_canonicalize() returns its status to the wrapper instead of raising an error inside icu_set_collation_attributes().

  • Peter Eisentrautsaw an earlier versiontrailerDiscussed error ownership in #34 and approved #35 in #36, before the remaining canonicalization-error branch was changed to return status to the wrapper.
Avoid potential UCollator leak for older ICU versions.
24 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 97% surepart of a posted patchsetmoderate changesfrom patchset #321 of 1 reviewer saw the final version

Takes only the leak-prevention objective from #32's first component, replacing its wider refactor with ucol_close(collator) immediately before the existing error report. This follows the simpler alternative proposed in #34; the error-consistency refactor was deferred.

  • Peter Eisentrautsaw the final versiontrailerReviewed #32 in #34 and proposed closing the collator immediately before ereport(), which is the implementation committed.
pg_locale.c: change ereport() to elog().
24 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Changes pg_ucol_open()'s internal NULL-locale guard from ereport() to elog() and clarifies its comment. Peter requested this in #30 and #33; no attachment contains the change.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 90% sureRequested elog() in #33 after reviewing the wrapper in #29, with coverage classified against the later final patchset #40.
Handle the "und" locale in ICU versions 54 and older.
23 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: pgsql: Add standard collation UNICODE
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #291 of 1 reviewer saw the final version

Lands #29's und-locale compatibility component, including the initdb unicode-collation update and regression tests. The only component-level difference is removal of unnecessary declaration reindentation, confirmed in #31.

  • Peter Eisentrautsaw the final versiontrailerRequested ordinary version conditionals in #28 and approved the revised und handling in #30.
Wrap ICU ucol_open().
23 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #291 of 1 reviewer saw the final version

The pg_ucol_open() wrapper component of #29 matches the committed changes in src/backend/utils/adt/pg_locale.c after whitespace normalization. The rest of the submitted series lands separately or is revised later.

  • Peter Eisentrautsaw the final versiontrailerReviewed wrapper naming, call-site coverage, and conditional compilation in #28, then approved the revised wrapper in #30.
Support language tags in older ICU versions (53 and earlier).
21 Mar 2023Jeff Davismaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #271 of 1 reviewer saw the final version

Lands the first component of #27, enabling language-tag attributes on ICU versions before 54. Changes from the attachment simplify a duplicated pg_is_ascii() condition and explain the conversion in comments, exactly as discussed in #28 and #29.

  • Peter Eisentrautsaw the final versiontrailerReviewed the compatibility patch in #28 and requested the redundant-condition cleanup and explanatory comments incorporated before commit.

Credits across 11 commits

Author
Jeff DavisLLM9
Reviewer
Peter Eisentraut9
Reported by
Peter Eisentraut1
Thomas Munro1
Committer
Jeff Davis11

N LLM means N of the credits come from LLM analysis, not from commit trailers.