pg_dump: Remove some dead code

Started by Peter Eisentrautabout 3 years ago2 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

I have found that the per-column atttypmod tracking in pg_dump isn't
actually used anywhere. (The values are read but not used for writing
out any commands.) This is because some time ago we started formatting
all types through format_type() on the server. So this dead code can be
removed.

Attachments:

0001-pg_dump-Remove-dead-code.patchtext/plain; charset=UTF-8; name=0001-pg_dump-Remove-dead-code.patchDownload+0-7
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: pg_dump: Remove some dead code

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

I have found that the per-column atttypmod tracking in pg_dump isn't
actually used anywhere. (The values are read but not used for writing
out any commands.) This is because some time ago we started formatting
all types through format_type() on the server. So this dead code can be
removed.

Good catch. LGTM.

regards, tom lane