Apr 2023

2 commits
Support long distance matching for zstd compression
6 Apr 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: refactoring basebackup.c (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #322 of 2 reviewers saw the final version

The long-distance component of #32 matches the commit diff across all 12 files, excluding blob IDs; only its commit message changed, as confirmed in #34. I disagree with the attribution in thread #42349 to #503476: that March 2022 proposal is an ancestor, while this thread supplies the matching April 2023 version, including src/common/compression.c and pg_dump/basebackup integration.

  • Tomas Vondrasaw the final versiontrailerReviewed long-mode format compatibility and requested a boolean field in #29 and #31, then reviewed and committed the final component in #34.
  • Jacob Championsaw the final versiontrailerBenchmarked long-distance matching and questioned its benefit and window-size controls in #7, after which the long-distance component received only light documentation, naming, and boolean-type changes.
pg_dump: Add support for zstd compression
5 Apr 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: zstd compression for pg_dump (not this thread)
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #321 of 3 reviewers saw the final version

Lands the main pg_dump zstd component of #32, leaving long-distance matching, threaded workers, and the temporary CI-default attachment outside this commit. Differences within that component are comments and formatting in compress_io.c, compress_zstd.c, pg_backup_archiver.c, and pg_dump.c, consistent with the push report #33.

  • Tomas Vondrasaw the final versiontrailerChallenged removal of supports_compression(), requested consistent suffix handling and deferral of workers, then polished and committed the final component #15 #18 #25 #33.
  • Jacob Championsaw an earlier versiontrailerBenchmarked and tested Windows dumps, identified Meson and stream-handling problems, and verified the revised build before subsequent changes added suffix cases and disabled worker support #7 #12 #13 #21.
  • Andreas Karlssonno review foundtrailerNo review activity appears in this thread; the commit explicitly says its reviewer list also incorporates the earlier proposal thread 84adc8e20f.

Credits across 2 commits

Author
Justin Pryzby2
Reviewer
Jacob Champion2
Tomas Vondra2
Andreas Karlsson1
Committer
Tomas Vondra2