model-writtenrun 4652 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Daniel Gustafsson proposed SysCacheGetAttrNotNull to replace repeated assertions and error checks with a wrapper that raises an error for unexpected null attributes, converting callers across 38 files in #1.
- Tom Lane supported centralizing the checks and requested catalog and column names in diagnostics in #2; Peter Eisentraut suggested passing a null isnull pointer instead in #3, but Tom and Daniel favored a distinct function for clearer backpatch failures and self-documenting calls in #4 and #5.
- Peter's detailed review requested shorter calls and removal of unlikely() in #6, and Daniel incorporated those changes and named catalog diagnostics in #8, while retaining existing checks where callers supplied valuable specialized errors.
- Daniel explained that callers can know an attribute is non-null even when its column lacks attnotnull in #7, so Tom withdrew his proposed restriction in #9 and reinforced the value of readable diagnostics for catalog corruption in #10.
- Daniel rebased the patch over conflicting ICU changes in #11, reporting that another search found no additional callers to convert.
- Peter refined the diagnostic to use lowercase 'null' and separate catalog and column names without hardcoding pg_catalog in #12; David Rowley supported the patch, requested formatting cleanup, and discussed the loss of caller-specific error locations in #13 and #15, with Daniel acknowledging the tradeoff in #16.
- Daniel committed #11 as d435f15fff with Peter's error wording and pgindent adjustments, announcing completion in #17 while investigating a buildfarm recoveryCheck failure he suspected was unrelated.
- After the commit, Justin Pryzby questioned whether looking up catalog names during a corruption error was safe in #18; Tom considered the risk acceptable and deferred caching catalog names unless actual problems emerged in #19, leaving the submitted work landed and analogous SearchSysCache wrappers only a possible future extension.