Mar 2024

1 commit
Fix errorhandling for reading from a pipe
8 Mar 2024Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #111 of 2 reviewers saw the final version

The commit retains the ERRCODE_NO_DATA substitution and removal of %m from #11 in src/common/exec.c, but omits the empty_ok parameter and all caller changes. This narrowing follows Álvaro's objection in #12 and Daniel's agreement in #13.

  • Peter Eisentrautsaw the final versionLLM analysis, 95% surePeter identified the bogus no-data diagnostic in the landed #9 implementation at #10 and reiterated removing %m at #14; the committed correction makes only light diagnostic changes to that reviewed code.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 92% sureÁlvaro reviewed #11 and rejected its unused empty_ok option at #12, after which the API extension and its conditional behavior were removed before committing.

Feb 2024

1 commit
Refactor pipe_read_line to return the full line
9 Feb 2024Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #90 of 3 reviewers saw the final version

The complete four-file diff matches #9 after excluding index-hash widths and hunk metadata, including the allocated-buffer API, caller updates, and error handling.

  • Heikki Linnakangassaw an earlier versiontrailerHeikki approved the approach and requested explicit allocation documentation at #3, before the later errno and ferror() logic changes.
  • Álvaro Herrerasaw an earlier versiontrailerÁlvaro supported the change at #7 and requested errno preservation, error details, and ferror() handling, which introduced local error-handling changes in the next revision.
  • John Naylorsaw an earlier versiontrailerJohn gave a +1 at #6 to #5, before the subsequent errno and ferror() logic changes.

Credits across 2 commits

Author
Daniel GustafssonLLM2
Reviewer
Alvaro Herrera1
Heikki Linnakangas1
John Naylor1
Reported by
Peter Eisentraut1
Committer
Daniel Gustafsson2

N LLM means N of the credits come from LLM analysis, not from commit trailers.