Nov 2023

9 commits
docs: meson: Change what 'docs' target builds
21 Nov 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: MacOS: xsltproc fails with "warning: failed to load external entity" (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #521 of 1 reviewer saw the final version

Exactly matches the attachment in #52 across doc/src/sgml/Makefile, docguide.sgml, and meson.build: docs gains manpages, the HTML-only instruction becomes ninja html, and Make's all target moves beside html. This contradicts the from_discussion attribution in thread #47343: that thread supplied earlier discussion, while this thread contains the later matching patch.

  • Peter Eisentrautsaw the final versiontrailerApproved the first four patches of #52 in #53, including the unchanged docs-target patch.
meson: Add 'world' target
21 Nov 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #521 of 1 reviewer saw the final version

The world alias in meson.build exactly matches #52, depending on all_built and docs.

  • Peter Eisentrautsaw the final versiontrailerFlagged missing manpages from world in #48 and approved the final series after docs gained that dependency in #53.
meson: docs: Add {html,man} targets, rename install-doc-*
21 Nov 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #521 of 2 reviewers saw the final version

Exactly matches the doc/src/sgml/meson.build attachment in #52, adding html/man aliases and renaming the installation aliases to install-html/install-man.

  • Christoph Bergsaw an earlier versiontrailerIn #25, identified that the proposed build aliases incorrectly installed documentation; their dependencies were corrected before the subsequent naming changes.
  • Peter Eisentrautsaw the final versiontrailerRequested html/man names matching make in #48 and approved the resulting patch in #53.
meson: Document build targets, add 'help' target
21 Nov 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #521 of 1 reviewer saw the final version

The help-target attachment in #52 matches every changed file after whitespace normalization; the only content presentation adjustment is column spacing in doc/src/sgml/targets-meson.txt, requested in #53.

  • Peter Eisentrautsaw the final versiontrailerReviewed the shared help/documentation design in #45 and #48, then approved the final patch with spacing suggestions in #53.
meson: Change default of 'selinux' feature option to auto
17 Nov 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

Exactly matches the one-line meson_options.txt change from disabled to auto in #41.

  • Peter Eisentrautsaw the final versiontrailerSupported the default change in #26 and explicitly approved its attached implementation in #48.
docs: Document --with-selinux/-Dselinux options centrally
17 Nov 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #411 of 1 reviewer saw the final version

Matches the SELinux documentation patch in #41 except for changing two occurrences of 'selinux' to 'SElinux' in installation.sgml following the capitalization review in #48.

  • Peter Eisentrautsaw the final versiontrailerApproved the documentation subject to capitalizing the product name in #48.
meson: Fix doc installation path computation
9 Nov 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #342 of 2 reviewers saw the final version

Exactly matches the first attachment in #34, applying the conditional package-name suffix to dir_doc in meson.build.

  • Tristan Partinsaw the final versiontrailerApproved the attached fixes in #39.
  • Andres Freundsaw the final versiontrailerAgreed with the installation corrections in #40.
meson: Install missing example files
9 Nov 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #342 of 2 reviewers saw the final version

All 23 added lines match the second attachment in #34, defining contrib documentation destinations and installing four contrib/spi example files.

  • Tristan Partinsaw the final versiontrailerSaid the attached fixes looked good in #39.
  • Andres Freundsaw the final versiontrailerEndorsed Peter's installation fixes in #40.
meson: docs: Install all manpages, not just ones in man1
3 Nov 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.1
LLM analysis, 100% surelanded as postedfrom patchset #24

Exactly matches the first attachment in #24, restoring input: man and @INPUT@ expansion so every manpage output directory is installed. Christoph Berg reported the existing regression in #21, but no review of the attached fix precedes its commit.

Mar - Apr 2023

9 commits
meson: docs: Allow configuring simple/website style
5 Apr 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

No attachment introduces docs_html_style; the commit adds that Meson option and its installation.sgml documentation, implementing the configurable stylesheet request in #1 and proposal in #2.

  • Justin Pryzbyno review foundtrailerThe commit credits Justin Pryzby, but he has no message or identifiable review activity in the supplied thread.
docs: html: load stylesheet via custom.css.source
5 Apr 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 96% suremodified before commitlight changesfrom patchset #81 of 1 reviewer saw the final version

Retains the custom.css.source mechanism and identical stylesheet.css.xml wrapper from #8. It accommodates the separate cleanup and htmlhelp removal, places parameters in stylesheet-html-common.xsl, and corrects the website CSS URL.

  • Peter Eisentrautsaw the final versionLLM analysis, 97% sureQuestioned the original CSS complexity in #4 and endorsed the replacement XML-wrapper solution in #9, after which only small adjustments remained.
docs: html: copy images to output as part of xslt build
5 Apr 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #81 of 1 reviewer saw the final version

The write-image template and imageobject handling match #8; htmlhelp hunks disappear because that format was removed, and stylesheet.xsl retains and tidies comments requested in #4.

  • Peter Eisentrautsaw the final versionLLM analysis, 99% sureReviewed XSLT image copying, discussed its SVG/XML limitations, and requested preserving the filename-stripping comment in #4.
meson: docs: Preparatory cleanups
5 Apr 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: what should install-world do when docs are not available? (part of a posted patchset)
docs: Remove support for 'htmlhelp' format
5 Apr 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

No attached patch removes htmlhelp; the deletion of its Makefile/Meson targets and stylesheet-hh.xsl implements the removal proposed in #9 and accepted by Andres in #10.

  • Peter Eisentrautsaw the final versionLLM analysis, 99% sureProposed removing htmlhelp instead of extending its stylesheet integration in #9, which became the committed approach.
  • Daniel Gustafssonsaw the final versionLLM analysis, 94% sureExplicitly expressed no objection to removing htmlhelp after considering its apparent lack of users in #11.
meson: make install_test_files more generic, rename to install_files
24 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3

The install_files implementation and meson.build integration match #3; only the helper's introductory comment is expanded to explain documentation installation.

meson: add install-{docs,doc-html,doc-man} targets
24 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #3

Takes the documentation installation targets from #3 while omitting that attachment's experimental Texinfo block. It also substitutes direct target arguments for input/@INPUT@ handling, subsequently identified as the manpage installation regression in #21.

meson: add install-{quiet, world} targets
24 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3

Preserves the install-quiet/install-world implementation, gettext dependency collection, and libpq test-target changes from #3. The committed meson.build reorganizes installation targets and adds explanatory comments without changing the proposed logic.

meson: rename html_help target to htmlhelp
21 Mar 2023Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Exactly matches the two html_help-to-htmlhelp substitutions in doc/src/sgml/meson.build from #3.

  • Peter Eisentrautsaw the final versionLLM analysis, 100% sureExplicitly reviewed the rename and called it obvious in #4, before it was committed.

Credits across 18 commits

Author
Andres FreundLLM14
Peter EisentrautLLM2
Reviewer
Peter Eisentraut6
Andres Freund2
Tristan Partin2
Christoph Berg1
Justin Pryzby1
Reported by
Peter Eisentraut4
Christoph Berg2
Committer
Andres Freund16
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.