Comment typo in recent push
There seems to be a comment typo in the recent commit "Perform logical
replication actions as the table owner" [1]https://github.com/postgres/postgres/commit/1e10d49b65d6c26c61fee07999e4cd59eab2b765.
/*
* Switch back to the original user ID.
*
* If we created a new GUC nest level, also role back any changes that were
* made within it.
*/
/role back/rollback/
~~
PSA a tiny patch to fix that.
------
[1]: https://github.com/postgres/postgres/commit/1e10d49b65d6c26c61fee07999e4cd59eab2b765
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachments:
v1-0001-Fix-comment-typo.patchapplication/octet-stream; name=v1-0001-Fix-comment-typo.patchDownload
From 69d8d1ded808a2121a16debef6f2db7ab961b68a Mon Sep 17 00:00:00 2001
From: Peter Smith <peter.b.smith@fujitsu.com>
Date: Wed, 5 Apr 2023 09:49:25 +1000
Subject: [PATCH v1] Fix comment typo
---
src/backend/utils/init/usercontext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/utils/init/usercontext.c b/src/backend/utils/init/usercontext.c
index 88a7e55..4f5078b 100644
--- a/src/backend/utils/init/usercontext.c
+++ b/src/backend/utils/init/usercontext.c
@@ -80,7 +80,7 @@ SwitchToUntrustedUser(Oid userid, UserContext *context)
/*
* Switch back to the original user ID.
*
- * If we created a new GUC nest level, also role back any changes that were
+ * If we created a new GUC nest level, also rollback any changes that were
* made within it.
*/
void
--
1.8.3.1
On Tue, Apr 4, 2023 at 8:29 PM Peter Smith <smithpb2250@gmail.com> wrote:
There seems to be a comment typo in the recent commit "Perform logical
replication actions as the table owner" [1]./*
* Switch back to the original user ID.
*
* If we created a new GUC nest level, also role back any changes that were
* made within it.
*//role back/rollback/
~~
PSA a tiny patch to fix that.
Good catch, but I think it should be roll back (a verb) not rollback (a noun).
--
Robert Haas
EDB: http://www.enterprisedb.com