Jun 2023

1 commit
fd.c: Retry after EINTR in more places
19 Jun 2023Andres Freundmaster16beta2REL_19_STABLE16beta2REL_18_STABLE16beta2REL_17_STABLE16beta2REL_16_STABLE16beta2
LLM analysis, 100% surelanded as postedfrom patchset #165 of 5 reviewers saw the final version

Applying the hunks from #16 to the commit's parent produces src/backend/storage/file/fd.c byte-for-byte identical to 0d369ac650. The commit message also matches; different diff alignment around pg_truncate() represents no content change.

  • Melanie Plagemansaw the final versionLLM analysis, 94% sureBefore the first attachment, Melanie identified FileFallocate()'s missing EINTR retry and proposed the retry approach adopted in both submissions #3.
  • Christoph Bergsaw the final versionLLM analysis, 100% sureChristoph reported successful builds with #5 applied and later confirmed continued success in the Debian package, with only light changes following #6 #14.
  • Thomas Munrosaw the final versionLLM analysis, 99% sureThomas examined signal-induced retry starvation and judged #5 reasonable because its file extensions are bounded, with only light changes following #7.
  • Kyotaro Horiguchisaw the final versionLLM analysis, 97% sureKyotaro reviewed the retry strategy in #5, raising repeated-interruption concerns and arguing for signal blocking, with only light changes following #10 #12.
  • Alvaro Herrerasaw the final versionLLM analysis, 90% sureAlvaro assessed the compatibility risk of leaving some retries at the File* layer in #5 as minor, an assessment Andres accepted while retaining the design #13 #15.

Credits across 1 commit

Author
Andres FreundLLM1
Reported by
Christoph Berg1
Committer
Andres Freund1

N LLM means N of the credits come from LLM analysis, not from commit trailers.