Sep 2024

3 commits
Remove obsolete unconstify()
11 Sep 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #1161 of 1 reviewer saw the final version

The single-line removal of unconstify() in src/backend/libpq/be-secure-openssl.c exactly matches #116, including its stable patch ID.

  • Daniel Gustafssonsaw the final versiontrailerDaniel endorsed the cleanup in #117 and raised the related question of documenting minimum LibreSSL support.
Only perform pg_strong_random init when required
2 Sep 2024Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1142 of 3 reviewers saw the final version

Commits only the RNG-initialization member of the two-patch series #114; its src/port/pg_strong_random.c diff matches exactly. The other series member landed separately.

  • Jacob Championsaw an earlier versiontrailerJacob reviewed and tested the earlier combined patch in #60 and #65, before RNG initialization was split out and its behavior revised.
  • Peter Eisentrautsaw the final versiontrailerPeter identified the post-fork initialization flaw in #80 and approved the later series in #101, requesting only commit-message corrections.
  • Michael Paquiersaw the final versiontrailerMichael reviewed the initialization strategy, caught the version-boundary error in #78 and approved the final RNG implementation in #88.
Remove support for OpenSSL older than 1.1.0
2 Sep 2024Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1142 of 3 reviewers saw the final version

Commits the OpenSSL support-removal member of #114, with matching source changes across build checks, libpq, pgcrypto, documentation and tests. The separate RNG patch is excluded.

  • Jacob Championsaw an earlier versiontrailerJacob identified the LibreSSL incompatibility in #35, supplied corrections in #54 and reported extensive version testing in #65, before the minimum-version and initialization changes.
  • Peter Eisentrautsaw the final versiontrailerPeter challenged version probing, requested the split, found leftover declarations in #99 and approved the corrected series in #101.
  • Michael Paquiersaw the final versiontrailerMichael reviewed the compatibility cleanup and expanded initialization removal in #91, then approved the documentation in #98, after which only light cleanup and rebasing followed.

Apr 2024

3 commits
Support SSL_R_VERSION_TOO_LOW when using LibreSSL
24 Apr 2024Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #812 of 2 reviewers saw the final version

Commits only the SSL_R_VERSION_TOO_LOW member of the five-patch series #81. Its separate conditional guard in be-secure-openssl.c matches the attached patch exactly.

  • Peter Eisentrautsaw the final versiontrailerPeter requested a separate patch in #72 and accepted its code in #80 while requesting a clearer explanation of LibreSSL's missing SSL_R_VERSION_TOO_HIGH.
  • Michael Paquiersaw the final versiontrailerMichael supported applying the conditional LibreSSL fix in #76 and #78, then agreed with the final landing plan in #86.
Support disallowing SSL renegotiation when using LibreSSL
24 Apr 2024Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #812 of 2 reviewers saw the final version

Commits only the LibreSSL renegotiation member of #81. The SSL_OP_NO_CLIENT_RENEGOTIATION addition and accompanying comments in be-secure-openssl.c match exactly.

  • Peter Eisentrautsaw the final versiontrailerPeter requested separation in #72, approved the resulting patch in #80 and recommended PostgreSQL 17 testing before considering backpatching in #84.
  • Michael Paquiersaw the final versiontrailerMichael endorsed applying the renegotiation patch in #76, argued for backpatching in #78 and accepted the final landing plan in #86.
Doc: Use past tense for things which happened in the past
24 Apr 2024Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #812 of 2 reviewers saw the final version

Commits only the documentation member of #81, changing three descriptions of past SSL-compression changes to past tense in doc/src/sgml/libpq.sgml. Its diff matches exactly.

  • Peter Eisentrautsaw the final versiontrailerPeter recommended immediate separate application of the documentation change in #72 and explicitly approved the split patch in #80.
  • Michael Paquiersaw the final versiontrailerMichael said the documentation patch looked sensible in #76, supported its application in #78 and accepted the final plan in #86.

Jul 2023

1 commit
Remove support for OpenSSL 1.0.1
3 Jul 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #102 of 2 reviewers saw the final version

All added and removed lines match the sole patch in #10, including USE_SSL guards, SCRAM tests and OPENSSL_API_COMPAT changes. Differences are file ordering and rebased Meson context.

  • Jacob Championsaw the final versiontrailerJacob reviewed Meson rejection of unsupported libraries and an obsolete test comment in #12; the committed source patch remained unchanged.
  • Daniel Gustafssonsaw the final versiontrailerDaniel requested USE_SSL guards and comment corrections in #7, then approved the revised patch in #11.

Credits across 7 commits

Author
Daniel GustafssonLLM5
Michael PaquierLLM1
Peter EisentrautLLM1
Reviewer
Michael Paquier5
Peter Eisentraut5
Jacob Champion3
Daniel Gustafsson2
Committer
Daniel Gustafsson5
Michael Paquier1
Peter Eisentraut1

N LLM means N of the credits come from LLM analysis, not from commit trailers.