model-writtenrun 3003 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
May - Jul 2023 · 5 entries
- Michael Paquier proposed separate removals of OpenSSL 1.0.1 and 1.0.2 support, simplifying channel binding and compatibility code while identifying unresolved LibreSSL locking and initialization issues #1.
- Daniel Gustafsson pointed out continued commercial and distribution support for OpenSSL 1.0.2, and Michael agreed to defer that removal while proceeding with 1.0.1 #2 #3.
- Daniel's review led Michael to use the SSL abstraction guards, remove redundant declaration guards and correct comments and Meson settings in the revised 1.0.1 patch #7 #10; Jacob Champion's request for earlier build-time rejection was left for separate work #12 #15 #16.
- Michael committed the revised 1.0.1 removal unchanged apart from rebasing as 8e278b6576, announcing its application at the start of the PostgreSQL 17 development cycle #10 #17.
- The removal exposed unsupported buildfarm installations: an old OpenBSD animal was retired and SSL was disabled on an affected Debian installation, rather than restoring obsolete library support #18 #21 #22 #24.
Sep 2023 · 1 entry
- Thomas Munro challenged using commercial extended support as the dependency cutoff, then reopened the question in March 2024 by suggesting an OpenSSL 3 minimum; Tom Lane argued that supported RHEL 8 installations still needed OpenSSL 1.1.1 compatibility #26 #29 #30 #31.
Mar - May 2024 · 10 entries
- Daniel revived the deferred cleanup with a broader patch requiring OpenSSL 1.1.1 and removing libcrypto locking callbacks, then rebased it over new HMAC resource-owner changes #33 #34.
- Buildfarm and distribution discussions initially delayed agreement, but Tom accepted dropping 1.0.2 after establishing that new PostgreSQL releases would not be packaged for RHEL 7; retaining OpenSSL 1.1.1 remained necessary for newer distributions #36 #45 #48.
- Jacob found that LibreSSL lacked X509_get_signature_info(), then supplied a revised patch restoring necessary capability checks, removing obsolete pgcrypto initialization and adding the now-required OpenSSL header #35 #54.
- Michael's review prompted removal of obsolete protocol compatibility routines and examination of RNG fork safety; Daniel added explicit library-version checks and LibreSSL renegotiation and error-reporting support, then fixed the Windows probe and regenerated configuration definitions #55 #58 #64.
- Jacob reported successful testing across LibreSSL and OpenSSL versions, while Peter Eisentraut and Tom objected to explicit version probes; Daniel replaced those probes with an EVP_PKEY_new_CMAC_key capability check #65 #61 #66 #68 #69.
- Peter proposed separating the 1.1.0 API cleanup from 1.1.1 RNG behavior and splitting independent fixes, leading Daniel to produce five patches with a 1.1.0 minimum and separate documentation, LibreSSL and RNG changes #72 #75.
- Michael corrected the patch split and the OpenSSL version boundary, but Peter then identified that a static initialization flag would not guarantee reseeding after fork; Daniel restored the post-fork initialization hook and made RAND_poll conditional on OpenSSL older than 1.1.1 #76 #78 #80 #81.
- Although Michael favored backpatching the LibreSSL changes, Peter recommended introducing them in PostgreSQL 17 first because coverage was limited and the documentation and error-message changes did not justify backpatching #78 #84.
- Daniel committed three unchanged members of #81: the documentation correction as 91d6429fad, LibreSSL renegotiation control as 44e27f0a6d and the SSL_R_VERSION_TOO_LOW guard as d80f2ce294, then resubmitted the two remaining patches for PostgreSQL 18 #87.
- Michael identified further obsolete initialization machinery, and Daniel expanded the remaining removal patch so PQinitSSL and PQinitOpenSSL became compatibility no-ops; subsequent discussion clarified documentation for applications that also target older libpq versions #88 #90 #91 #94 #97.
Jul - Sep 2024 · 4 entries
- After the May-to-July gap, Peter found leftover declarations in libpq-int.h; Daniel removed them in a rebased series, which Peter approved with only commit-message corrections requested #99 #100 #101.
- Joe Conway raised concerns about RHEL 7 users, Devrim GÜNDÜZ confirmed that newer PostgreSQL packages no longer targeted that platform, and Joe subsequently withdrew his reservations #103 #104 #110.
- Daniel posted the final rebased series and committed its two source-identical members separately: removal of OpenSSL older than 1.1.0 as a70e01d430 and conditional RNG initialization as c3333dbc0c, with buildfarm owners notified #114 #115.
- Peter supplied a follow-up removing an obsolete unconstify() call now that OpenSSL 1.1.0 was the minimum; Daniel endorsed it, and it landed unchanged as 1fb2308e69, while documentation of the minimum supported LibreSSL version remained an open question #116 #117.
Dec 2024 · 1 entry
- The final exchange concerned snakefly buildfarm failures rather than another source fix: Tom recommended updating its old client to expose setup diagnostics, and Robins Tharakan reported that the new client worked while compiler and scheduling configuration still needed attention #118 #119 #121.