model-writtenrun 4315 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Daniel Gustafsson proposed adding fail_ok support to Cluster.pm's restart method so SSL tests could exercise failed restarts without manually invoking pg_ctl or calling the internal _update_pid method #1.
- Melih Mutlu agreed that the tests became more readable and requested that restart return 1 on success and that two further SSL restart tests use the wrapper #2.
- Daniel Gustafsson incorporated those requests, documented fail_ok, and corrected the successful passphrase test to call restart instead of start in the revised patch #3.
- Heikki Linnakangas accepted the approach while observing that it makes failure tests more lenient because a PID file remaining after a timeout no longer triggers an error #4.
- Daniel Gustafsson accepted that behavior and committed #3 unchanged apart from rebasing as 33774978c7; his closing message confirmed completion and planned extra CFBot monitoring because relatively few buildfarm animals run SSL tests #5.