Aug 2023

2 commits
Fix erroneous -Werror=missing-braces on old GCC
10 Aug 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #143 of 3 reviewers saw the final version

The single hunk in src/bin/pgbench/pgbench.c exactly matches #14, including the declaration relocation, nested braces, and GCC bug comment; Peter confirmed the landing in #17.

  • Julien Rouhaudsaw the final versionLLM analysis, 98% sureConfirmed that the warning was a known compiler bug and endorsed the previously used nested-brace remedy in #15.
  • Richard Guosaw the final versionLLM analysis, 100% sureReported the same warning with GCC 4.8.5 and explicitly supported the nested-brace fix in #16.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Fix last remaining uninitialized memory warnings
9 Aug 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #112 of 2 reviewers saw the final version

Both source hunks exactly match #11: vargs receives a zero initializer and PGBT_NO_VALUE receives an explicit zero value. The only substantive textual edit is the commit message specifying GCC version 13.

  • Gurjeet Singhsaw the final versionLLM analysis, 100% sureAnalyzed evaluateExpr initialization paths and endorsed initialization at declaration in #2; subsequent changes only made the enum's existing zero value explicit and clarified the commit message.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Tristan Partin2
Reviewer
Peter Eisentrautcommitter2
Committer
Peter Eisentraut2