Typo in src/backend/access/nbtree/README?
Hi,
I am not a native English speaker, but shouldn't there be a "to" before "detect"?
These two additions make it possible detect a concurrent page split
Regards
Daniel
On Thu, Jun 8, 2023 at 7:11 AM Daniel Westermann (DWE)
<daniel.westermann@dbi-services.com> wrote:
... shouldn't there be a "to" before "detect"?
These two additions make it possible detect a concurrent page split
Agreed. Attached is a small patch that fixes this.
Thanks for the report!
Best regards,
Gurjeet
http://Gurje.et
Attachments:
v1-0001-Fix-grammar.patchapplication/x-patch; name=v1-0001-Fix-grammar.patchDownload
From f694a97e72a3ad744073c9a04f3c39615b1a9987 Mon Sep 17 00:00:00 2001
From: Gurjeet Singh <gurjeet@singh.im>
Date: Thu, 8 Jun 2023 19:30:57 -0700
Subject: [PATCH v1] Fix grammar
As reported by Daniel Westermann.
---
src/backend/access/nbtree/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/access/nbtree/README b/src/backend/access/nbtree/README
index dd0f7ad2bd..1174ab9131 100644
--- a/src/backend/access/nbtree/README
+++ b/src/backend/access/nbtree/README
@@ -17,7 +17,7 @@ The basic Lehman & Yao Algorithm
Compared to a classic B-tree, L&Y adds a right-link pointer to each page,
to the page's right sibling. It also adds a "high key" to each page, which
is an upper bound on the keys that are allowed on that page. These two
-additions make it possible detect a concurrent page split, which allows the
+additions make it possible to detect a concurrent page split, which allows the
tree to be searched without holding any read locks (except to keep a single
page from being modified while reading it).
--
2.35.1
On Fri, Jun 9, 2023 at 10:37 AM Gurjeet Singh <gurjeet@singh.im> wrote:
On Thu, Jun 8, 2023 at 7:11 AM Daniel Westermann (DWE)
<daniel.westermann@dbi-services.com> wrote:... shouldn't there be a "to" before "detect"?
These two additions make it possible detect a concurrent page split
Agreed. Attached is a small patch that fixes this.
+1. A little nitpick: the new line seems overly long compared to
adjacent lines, should we wrap it?
Thanks
Richard
On Fri, Jun 09, 2023 at 11:29:02AM +0800, Richard Guo wrote:
On Fri, Jun 9, 2023 at 10:37 AM Gurjeet Singh <gurjeet@singh.im> wrote:
On Thu, Jun 8, 2023 at 7:11 AM Daniel Westermann (DWE)
<daniel.westermann@dbi-services.com> wrote:... shouldn't there be a "to" before "detect"?
These two additions make it possible detect a concurrent page split
Agreed. Attached is a small patch that fixes this.
+1. A little nitpick: the new line seems overly long compared to
adjacent lines, should we wrap it?
Committed, thanks.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com