model-writtenrun 4208 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Smith proposed centralizing logical replication worker names in macros to prevent inconsistent terminology, and Amit Kapila initially supported the cleanup #1 #2.
- Alvaro Herrera objected that inserting worker names into sentence fragments prevents grammatically correct translations, while Kyotaro Horiguchi also found that the patch complicated source searches without reducing translatable messages #3 #4.
- Peter Smith pointed out that existing code already assembled messages using get_worker_name(), but Alvaro Herrera argued that this existing pattern should itself be removed rather than extended #5 #6.
- Peter Eisentraut supplied a separate PostgreSQL 16 translation fix that removed get_worker_name() and restored complete message strings, initially treating the affected messages as apply-worker messages #7.
- Peter Smith explained that tablesync workers could also reach these logging paths, leading Peter Eisentraut to propose the broader wording "logical replication worker" #8 #9.
- Masahiko Sawada and Alvaro Herrera endorsed the generic wording before the change was committed #10 #11.
- The translation fix from #7 landed with five wording adjustments as development commit e1c83e7b96 and its PostgreSQL 16 counterpart b4018ecb88; these listed candidates represent one change.
- Peter Eisentraut closed the thread by confirming the commit; the translation fix was complete, while Peter Smith's original macro cleanup remained uncommitted following the translation objections #12 #1 #3.