subscription/033_run_as_table_owner is not listed in the meson.build
Dear hackers,
I have noticed that the testcase subscription/033_run_as_table_owner in the
subscription is not executed when meson build system is chosen. The case is not
listed in the meson.build.
Do we have any reasons or backgrounds about it?
PSA the patch to add the case. It works well on my env.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
Attachments:
add_test.patchapplication/octet-stream; name=add_test.patchDownload
diff --git a/src/test/subscription/meson.build b/src/test/subscription/meson.build
index f85bf92b6f..bd673a9d68 100644
--- a/src/test/subscription/meson.build
+++ b/src/test/subscription/meson.build
@@ -39,6 +39,7 @@ tests += {
't/030_origin.pl',
't/031_column_list.pl',
't/032_subscribe_use_index.pl',
+ 't/033_run_as_table_owner.pl',
't/100_bugs.pl',
],
},
On Thu, Jun 15, 2023 at 07:16:06AM +0000, Hayato Kuroda (Fujitsu) wrote:
I have noticed that the testcase subscription/033_run_as_table_owner in the
subscription is not executed when meson build system is chosen. The case is not
listed in the meson.build.Do we have any reasons or backgrounds about it?
PSA the patch to add the case. It works well on my env.
Seems like a thinko of 4826759 to me, that's easy to miss. Will fix
in a bit..
--
Michael
On Thu, Jun 15, 2023 at 5:04 PM Michael Paquier <michael@paquier.xyz> wrote:
On Thu, Jun 15, 2023 at 07:16:06AM +0000, Hayato Kuroda (Fujitsu) wrote:
I have noticed that the testcase subscription/033_run_as_table_owner in the
subscription is not executed when meson build system is chosen. The case is not
listed in the meson.build.Do we have any reasons or backgrounds about it?
PSA the patch to add the case. It works well on my env.Seems like a thinko of 4826759 to me, that's easy to miss. Will fix
in a bit..
Good catch.
Checking similar oversights,
src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be
listed in meson.build too.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Thu, Jun 15, 2023 at 5:32 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
On Thu, Jun 15, 2023 at 5:04 PM Michael Paquier <michael@paquier.xyz> wrote:
On Thu, Jun 15, 2023 at 07:16:06AM +0000, Hayato Kuroda (Fujitsu) wrote:
I have noticed that the testcase subscription/033_run_as_table_owner in the
subscription is not executed when meson build system is chosen. The case is not
listed in the meson.build.Do we have any reasons or backgrounds about it?
PSA the patch to add the case. It works well on my env.Seems like a thinko of 4826759 to me, that's easy to miss. Will fix
in a bit..Good catch.
Checking similar oversights,
src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be
listed in meson.build too.
Here is the patch for that.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Attachments:
0001-Add-missing-pg_basebackup-TAP-test-for-meson.patchapplication/octet-stream; name=0001-Add-missing-pg_basebackup-TAP-test-for-meson.patchDownload
From 6b9784034bc4511763549e42c9f1a5b07bafa0ec Mon Sep 17 00:00:00 2001
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri, 16 Jun 2023 06:55:48 +0900
Subject: [PATCH] Add missing pg_basebackup TAP test for meson.
011_in_place_tablespace was missing from the list of pg_basebackup
tests to run under meson, so add it.
Oversight in 363e8f9115.
Discussion: https://postgr.es/m/CAD21AoDTh1A8bvNBF3LQNQg=27xTpSgvpT+4_yyEj6p4Zv8unA@mail.gmail.com
---
src/bin/pg_basebackup/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/bin/pg_basebackup/meson.build b/src/bin/pg_basebackup/meson.build
index c684622bfb..c426173db3 100644
--- a/src/bin/pg_basebackup/meson.build
+++ b/src/bin/pg_basebackup/meson.build
@@ -86,6 +86,7 @@ tests += {
},
'tests': [
't/010_pg_basebackup.pl',
+ 't/011_in_place_tablespace.pl',
't/020_pg_receivewal.pl',
't/030_pg_recvlogical.pl',
],
--
2.31.1
On Fri, Jun 16, 2023 at 07:15:36AM +0900, Masahiko Sawada wrote:
On Thu, Jun 15, 2023 at 5:32 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
Checking similar oversights,
src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be
listed in meson.build too.Here is the patch for that.
Yes, good catch.
--
Michael
On Fri, Jun 16, 2023 at 7:42 AM Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Jun 16, 2023 at 07:15:36AM +0900, Masahiko Sawada wrote:
On Thu, Jun 15, 2023 at 5:32 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
Checking similar oversights,
src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be
listed in meson.build too.Here is the patch for that.
Yes, good catch.
Pushed.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com