Fix a typo in rewriteHandler.c
Hi,
I've attached the patch for the following rewriteTargetView comments.
Assert(parsetree->resultRelation == new_rt_index);
/*
* For INSERT/UPDATE we must also update resnos in the targetlist to refer
* to columns of the base relation, since those indicate the target
* columns to be affected.
*
* Note that this destroys the resno ordering of the targetlist, but that
* will be fixed when we recurse through rewriteQuery, which will invoke
* rewriteTargetListIU again on the updated targetlist.
*/
if (parsetree->commandType != CMD_DELETE)
{
foreach(lc, parsetree->targetList)
s/rewriteQuery/RewriteQuery
regards,
Sho Kato
Attachments:
fix_typo_rewriteHandler.ctext/plain; name=fix_typo_rewriteHandler.cDownload+1-1
Hello,
On Thu, Jun 15, 2023 at 5:07 PM Sho Kato (Fujitsu) <kato-sho@fujitsu.com> wrote:
Hi,
I've attached the patch for the following rewriteTargetView comments.
Assert(parsetree->resultRelation == new_rt_index);
/*
* For INSERT/UPDATE we must also update resnos in the targetlist to refer
* to columns of the base relation, since those indicate the target
* columns to be affected.
*
* Note that this destroys the resno ordering of the targetlist, but that
* will be fixed when we recurse through rewriteQuery, which will invoke
* rewriteTargetListIU again on the updated targetlist.
*/
if (parsetree->commandType != CMD_DELETE)
{
foreach(lc, parsetree->targetList)s/rewriteQuery/RewriteQuery
Good catch and thanks for the patch. Will push shortly.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
On Fri, Jun 16, 2023 at 10:25 AM Amit Langote <amitlangote09@gmail.com> wrote:
On Thu, Jun 15, 2023 at 5:07 PM Sho Kato (Fujitsu) <kato-sho@fujitsu.com> wrote:
I've attached the patch for the following rewriteTargetView comments.
s/rewriteQuery/RewriteQuery
Good catch and thanks for the patch. Will push shortly.
Done.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com