model-writtenrun 7236 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Jacob Champion proposed preserving TAP temporary directories with PG_TEST_NOCLEAN after successful test_pg_dump runs deleted artifacts he wanted for debugging, extending the existing data-directory behavior to both temporary-directory helpers #1.
- Michael Paquier supported the change and requested documentation updates, while Daniel Gustafsson also supported the proposal #2 #3.
- Andrew Dunstan questioned how zero-valued settings should behave; Dagfinn Ilmari Mannsåker explained that definedness matched existing behavior and supplied the correct expression for a possible boolean interpretation #4 #5.
- Jacob added the requested documentation and supplied a separate second patch making zero and empty values permit cleanup for both data and temporary directories #6.
- Andrew favored boolean behavior, but Peter Eisentraut cautioned against imposing Perl truth semantics on environment variables, and Michael preferred retaining definedness checks; Jacob agreed that the second patch could be omitted #7 #8 #9 #10.
- Michael approved the retained first patch and proposed backpatching through PostgreSQL 11; Daniel agreed and requested a small README wording correction #11 #12.
- Michael committed the first patch from #6 as 8c12838001, incorporating Daniel's wording correction and minor editorial adjustments, then confirmed application across the supported branches #13.
- Although the commit also references the earlier discussion in thread #46549, the matching implementation and documentation were submitted here in #6, making this thread the source of 8c12838001.
- The thread ended with Jacob's thanks: temporary-directory preservation had landed, and the proposed boolean-semantics change had been dropped #14 #10.