Dec 2023

2 commits
Suppress -Wunused-result warning about write().
6 Dec 2023Nathan Bossartmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

Nathan supplied the inline fix after reporting a compiler error for ignoring write()'s return value #10. The commit reproduces that fix in src/bin/pg_test_fsync/pg_test_fsync.c, adding an rc variable and void cast with a warning-suppression comment c2a465b2c9.

  • Tristan Partinsaw the final versiontrailerTristan investigated the fortification-dependent warning and endorsed Nathan's inline fix #11, which had no attached patchset.
  • Peter Eisentrautsaw the final versiontrailerPeter corrected the earlier attached versions and assessed the final signal-safety patch #2 #4 #7, then explicitly endorsed Nathan's inline warning fix and requested its commit #13.
Use signal-safe functions in signal handler
6 Dec 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #51 of 1 reviewer saw the final version

The commit exactly matches the signal-safety patch in #5, replacing puts() and exit() with write(STDOUT_FILENO, "\n", 1) and _exit() in src/bin/pg_test_fsync/pg_test_fsync.c. It takes only that patch from the two-patch series, as Peter confirmed #9, leaving out the Windows changes.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Tristan Partin1
Reviewer
Peter Eisentrautcommitter2
Tristan Partin1
Committer
Nathan Bossart1
Peter Eisentraut1