Duplicated LLVMJitHandle->lljit assignment?

Started by Matheus Alcantaraalmost 3 years ago3 messageshackers
Jump to latest
#1Matheus Alcantara
mths.dev@pm.me

Hi,

I was reading the jit implementation and I notice that the lljit field of
LLVMJitHandle is being assigned twice on llvm_compile_module function, is this
correct? I'm attaching a supposed fixes that removes the second assignment. I
ran meson test and all tests have pass.

--
Matheus Alcantara

Attachments:

0001-Remove-duplicated-LLVMJitHandle-lljit-assignment.patchtext/x-patch; name=0001-Remove-duplicated-LLVMJitHandle-lljit-assignment.patchDownload+0-3
#2Gurjeet Singh
gurjeet@singh.im
In reply to: Matheus Alcantara (#1)
Re: Duplicated LLVMJitHandle->lljit assignment?

On Wed, Jul 12, 2023 at 5:22 PM Matheus Alcantara <mths.dev@pm.me> wrote:

I was reading the jit implementation and I notice that the lljit field of
LLVMJitHandle is being assigned twice on llvm_compile_module function, is this
correct? I'm attaching a supposed fixes that removes the second assignment. I
ran meson test and all tests have pass.

- handle->lljit = compile_orc;

LGTM.

Best regards,
Gurjeet
http://Gurje.et

#3Michael Paquier
michael@paquier.xyz
In reply to: Gurjeet Singh (#2)
Re: Duplicated LLVMJitHandle->lljit assignment?

On Wed, Jul 12, 2023 at 06:41:37PM -0700, Gurjeet Singh wrote:

LGTM.

Indeed. It looks like a small thinko from 6c57f2e when support for
LLVM12 was added.
--
Michael