Jan 2025

6 commits
Doc: Generated column replication.
30 Jan 2025Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #3323 of 3 reviewers saw the final version

Matches the first documentation patch in #332 modulo hunk placement; the second patch adding the extra Examples subsection was left out after #331.

  • Vignesh Csaw the final versiontrailerReviewed examples and command-output presentation in #183, incorporated by #185; subsequent documentation edits preserve that feature description.
  • Peter Eisentrautsaw the final versiontrailerReviewed documentation formatting and copyable examples in #308, followed by formatting fixes and removal of the optional examples.
  • Amit Kapilasaw the final versiontrailerRequested simpler section structure and separation of additional examples in #329 and #331, then reviewed the final version as committer.
Rename pubgencols_type to pubgencols in pg_publication.
28 Jan 2025Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #3262 of 2 reviewers saw the final version

All seven-file rename hunks match #326; the commit additionally bumps src/include/catalog/catversion.h.

  • Amit Kapilasaw the final versiontrailerApproved the rename in #327 and reviewed the committed version as committer.
  • Peter Smithsaw the final versiontrailerApproved the rename and checked its lack of expected-output changes in #328.
Doc: Fix column name in pg_publication catalog.
24 Jan 2025Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #3192 of 2 reviewers saw the final version

Matches #319 in doc/src/sgml/catalogs.sgml, correcting the column name and catalog ordering, apart from one blank line.

  • Peter Smithsaw the final versiontrailerExplicitly approved the catalog documentation correction in #320.
  • Amit Kapilasaw the final versioncommittercommitted the patch
Fix buildfarm failure introduced by commit e65dbc9927.
23 Jan 2025Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surelanded as postedfrom patchset #3171 of 1 reviewer saw the final version

The pg_dump.c fix is identical to #317, whose patch author timestamp precedes the commit although its email arrived about two minutes afterward; Daniel Gustafsson’s approval #318 postdates the commit.

  • Amit Kapilasaw the final versioncommittercommitted the patch
Change publication's publish_generated_columns option type to enum.
23 Jan 2025Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #3143 of 3 reviewers saw the final version

Takes the first patch of #314, including merged catalog documentation and test-name fixes, while leaving its documentation chapter pending; Amit retained char parsing types, adjusted comments/tests and added the catalog bump as explained in #316.

  • Peter Smithsaw the final versiontrailerReviewed the enum conversion through the final patch and explicitly approved it in #315.
  • Peter Eisentrautsaw the final versiontrailerApproved the enum patch in #308, followed only by small type, integration and presentation edits.
  • Amit Kapilasaw the final versiontrailerRequested integration of the supporting fixes in #307 and reviewed and edited the committed conversion in #316.
Fix \dRp+ output when describing publications with a lower server version.
22 Jan 2025Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #3032 of 2 reviewers saw the final version

Exactly matches the first patch of #303, adding fallback SQL aliases in src/bin/psql/describe.c; the four other patches were not part of this commit.

  • Peter Smithsaw the final versiontrailerProposed fixed query-column aliases in #299 and approved the final fix in #305.
  • Amit Kapilasaw the final versioncommittercommitted the patch

Oct - Nov 2024

3 commits
Replicate generated columns when 'publish_generated_columns' is set.
7 Nov 2024Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #2762 of 7 reviewers saw the final version

Combines both patches of #276, including Shubham’s TAP tests, with only an added src/include/catalog/catversion.h bump.

  • Peter Smithsaw the final versiontrailerReviewed implementation and tests throughout, including the final helper cleanup in #270 and behavioral testing in #274, before only light edits.
  • Amit Kapilasaw the final versiontrailerDirected the publication design and final helper/comment revisions in #267 and #273, and reviewed the final version as committer.
  • Hayato Kurodasaw an earlier versiontrailerReviewed compatibility and column handling and tested the misleading generated-target error in #248, before further helper and conflict-handling revisions.
  • Shlok Kyalsaw an earlier versiontrailerReported naming, documentation and test problems in #35, before the subscription-to-publication redesign.
  • Ajin Cheriansaw an earlier versiontrailerReported cross-version replication, pg_dump, pg_upgrade and conflicting-publication test results in #244 and #253, before subsequent implementation refactoring.
  • Hou Zhijiesaw an earlier versiontrailerDemonstrated a multi-publication column-list regression in #224, before the option remainder was revised and committed.
  • Masahiko Sawadasaw an earlier versiontrailerReviewed initial-copy consistency, publication precedence and replica identity in #9, #143 and #184, before the later implementation redesign.
Doc: Update the behavior of generated columns in Logical Replication.
4 Nov 2024Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #2493 of 3 reviewers saw the final version

Matches the two documentation changes in #249, with only “generated columns data” shortened to “generated columns” in logical-replication.sgml.

  • Peter Smithsaw the final versionLLM analysis, 99% sureReported the missing column-list documentation in #241 and approved #242 in #243, before the light caveat extension.
  • Ajin Cheriansaw the final versionLLM analysis, 98% sureProposed the pre-18 subscriber initial-copy caveat in #245, which was incorporated into #249.
  • Amit Kapilasaw the final versioncommittercommitted the patch
Replicate generated columns when specified in the column list.
30 Oct 2024Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #2381 of 4 reviewers saw the final version

The complete patch in #238 matches the commit’s changed lines; its From header names Hou Zhijie, identified in the thread by #224, while the commit also credits Shubham and Vignesh.

  • Peter Smithsaw an earlier versiontrailerReviewed column-list and initial-copy behavior through #231 on #226, before the older-publisher COPY logic fix in #238.
  • Hayato Kurodasaw an earlier versiontrailerReviewed expected test errors and tablesync logic in #220 and #230, before the subsequent older-publisher COPY fix.
  • Shlok Kyalsaw an earlier versiontrailerReviewed streaming-option documentation, macro naming and tests in #35, before substantial redesign and splitting.
  • Amit Kapilasaw the final versiontrailerReviewed the column-list split and initial-copy requirements in #219 and #229, supplied final comments and committed the patch.

Credits across 9 commits

Author
vignesh C7
Shubham Khanna2
Hou, Zhijie1
Peter Smith1
Shinoda, Noriyoshi (PN Japan FSIP)1
Reviewer
Amit Kapilacommitter9
Peter Smith6
Hayato Kuroda (Fujitsu)2
Peter Eisentraut2
Shlok Kyal2
Ajin Cherian1
Hou, Zhijie1
Masahiko Sawada1
vignesh C1
Reported by
Ajin Cherian1
Peter Smith1
Committer
Amit Kapila9