Jan 2024

3 commits
ALTER TABLE command to change generation expression
4 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #381 of 8 reviewers saw the final version

Commits the feature component of #38, incorporating its ADD COLUMN pass movement while leaving prerequisites to separate commits. In tablecmds.c the committer removes proposed dependency errors and adjusts hints and naming; generated.sql gains ANALYZE, as explained in #39.

  • jian hesaw an earlier versionLLM analysis, 99% sureTested partition expressions in #2 and confirmed correct behavior in #4 after identifying a schema-selection mistake.
  • Ajit Awekarsaw an earlier versionLLM analysis, 99% sureReported successful installcheck-world and feature testing, while flagging index, statistics, and materialized-view concerns in #5.
  • Vaibhav Dalvisaw an earlier versionLLM analysis, 99% sureReviewed formatting, completion ordering, comments, and parameter passing in #7, with changes incorporated in #9.
  • Vik Fearingsaw an earlier versionLLM analysis, 99% sureCritiqued shared SET/DROP handling and documentation, tested unnecessary rewrites, and proposed syntax changes in #8.
  • Maxim Orlovsaw an earlier versionLLM analysis, 99% sureConfirmed functionality and requested separate command implementations in #11, then gave a positive review in #23 before the constraint-handling rework.
  • Ashutosh Bapatsaw an earlier versionLLM analysis, 94% sureIdentified inheritance problems with converting ordinary columns in #13 and advocated ALTER TYPE rewrite semantics in #16.
  • Robert Haassaw an earlier versionLLM analysis, 95% sureProvided a concrete ALTER TYPE example in #19 supporting the adopted decision to treat expression changes as DDL without firing ordinary triggers.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Refactor: separate function to find all objects depending on a column
3 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #381 of 1 reviewer saw the final version

Extracts RememberAllDependentForRebuilding() from the refactoring component of #38, but omits ATPostAlterType* renaming. The committed helper takes colName directly and retains the dependency lock differently; #39 explicitly explains rejecting the broad renames.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Turn AT_PASS_* macros into an enum
1 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 94% surepart of a posted patchsetmoderate changesfrom patchset #381 of 1 reviewer saw the final version

Lands the enum prerequisite carried in #38, using Peter's fuller AlterTablePass conversion from #35, including additional parameter conversions and pgindent registration. It preserves the original pass ordering, moving the semantic reorder into the feature commit as documented in #39.

  • Amul Sulsaw the final versiontrailerAccepted and adapted Peter's enum patch in #36 and #38, including correct initialization and loop behavior retained in the committed conversion.

Credits across 3 commits

Author
Amul Sul2
Peter EisentrautLLM1
Reviewer
Peter Eisentrautcommitter2
Amul Sul1
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.