model-writtenrun 3740 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Amul Sul proposed changing an existing stored generated column's expression by updating its catalog expression and rewriting the table, initially sharing renamed SET/DROP routines in #1.
- Early testing confirmed partition behavior after jian he corrected a schema-selection mistake in #4, while Ajit Awekar reported successful tests and raised index, statistics, and materialized-view concerns in #5.
- Vaibhav Dalvi's code review in #7 and Vik Fearing's syntax review in #8 led to formatting fixes and a temporary STORED requirement in #9; Vik also questioned combined SET/DROP handling and unnecessary rewrites.
- Maxim Orlov recommended separating SET and DROP implementations in #11, while Ashutosh Bapat explained inheritance complications with converting ordinary columns in #13; Amul retained the narrower scope of changing already-generated columns in #14.
- Peter Eisentraut raised trigger and logical-decoding semantics in #15, but Ashutosh Bapat and Robert Haas argued for existing ALTER TYPE behavior in #16 and #19; Peter withdrew the trigger requirement after testing other databases in #21.
- After the October refresh in #20, Amul improved documentation and test ordering in #22, and Maxim gave a positive review in #23.
- Peter requested separate SET/DROP implementations and Db2-style SET EXPRESSION AS (...) syntax without STORED in #24, accepting Amul's dependency-management reason for dropping and recreating the expression in #26; Amul implemented that design in #27.
- Peter's questions about execution order in #28 and #30 prompted further testing, through which Amul discovered that rewritten values could violate CHECK and foreign-key constraints without errors in #31.
- Amul supplied an ALTER TYPE-based dependency-rebuilding prototype in #32, then replaced copied code with a shared helper, a dedicated execution pass, and constraint/index tests in #34.
- Peter demonstrated that expressions could not reference newly added columns and supplied an independent enum-conversion prerequisite in #35; Amul incorporated an adapted version into the series in #36.
- Peter proposed moving ADD COLUMN ahead of dependency rebuilding in #37, and Amul adopted that order with a combined ADD COLUMN/SET EXPRESSION regression test in #38.
- The enum prerequisite landed as cea89c93a1, drawing on Peter's original #35 and the integrated series in #38, while reserving the pass-order behavior change for the feature commit.
- The dependency-helper extraction from #38 landed as d4e66a39eb, with interface and locking adjustments and without the proposed broad function renames.
- The SET EXPRESSION feature from #38 landed as 5d06e99a3c, including the pass reorder, fewer dependency restrictions, and ANALYZE calls to stabilize plan tests.
- Peter announced completion in #39, explaining that the broad renames were unhelpful and the additional error cases lacked justification and tests; Amul acknowledged the completed work in #40, leaving no active patch awaiting review in this thread.