Aug 2023

1 commit
Introduce macros for protocol characters.
23 Aug 2023Nathan Bossartmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #435 of 8 reviewers saw the final version

The complete diff matches #43 after excluding Git index metadata and the email footer: 25 files, 305 additions and 204 deletions. Both the attachment and f4b54e1ed9 explicitly credit Dave Cramer, although Nathan Bossart submitted the attachment and committed it.

  • Alvaro Herrerasaw the final versiontrailerAlvaro proposed naming conventions, identified missed substitutions and an authentication naming problem #11, and supported extracting the header for third-party use #39, after which only header organization, installation and comment changes followed.
  • Tatsuo Ishiisaw the final versiontrailerTatsuo caught the Close/Describe subcommand naming problem #5, approved successive revisions, and requested the standalone header #35, explaining its dependency benefit #37 before the remaining header, installation and comment adjustments.
  • Peter Smithsaw an earlier versiontrailerPeter proposed an enum #13 and identified inconsistent ordering of definitions #23, before the later scope reduction, authentication macro refinement and tracing assertions in #34.
  • Robert Haassaw the final versiontrailerRobert requested names matching the protocol documentation #16 and explicitly expressed satisfaction with the final version #44.
  • Tom Lanesaw an earlier versiontrailerTom advocated searchable names matching the documentation #17 and reaffirmed canonical names with one prefix #30, before the scope reduction and tracing assertions introduced in #34.
  • Peter Eisentrautsaw an earlier versiontrailerPeter requested canonical protocol.sgml names, the PqMsg_ prefix and placement in pqcomm.h #28, before Nathan's scope reduction, tracing assertions and subsequent header extraction.
  • Michael Paquiersaw the final versiontrailerMichael questioned exposing c.h dependencies #38, then reviewed the standalone-header version and identified the missing MSVC installation and stale comments #42, both fixed in #43.
  • Nathan Bossartsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Dave Cramer1
Reviewer
Alvaro Herrera1
Michael Paquier1
Nathan Bossartcommitter1
Peter Eisentraut1
Peter Smith1
Robert Haas1
Tatsuo Ishii1
Tom Lane1
Committer
Nathan Bossart1