Minor configure/meson cleanup

Started by Thomas Munroover 2 years ago4 messageshackers
Jump to latest
#1Thomas Munro
thomas.munro@gmail.com

0001: There is no point in searching -lrt and -lposix4 for fdatasync()
if it's supposed to help Solaris only. They moved all the realtime
stuff into the main C library at least as far back as Solaris
10/OpenSolaris.

0002: There is no point in probing -lposix4 for anything. That was
superseded by -lrt even longer ago.

We could go further: I suspect the only remaining -lrt search we
still need in practice is for shm_open() on glibc < 2.34, but here I
just wanted to clean out some old Sun stuff that was called out by
name.

Attachments:

0001-Don-t-probe-extra-libraries-for-fdatasync.patchtext/x-patch; charset=US-ASCII; name=0001-Don-t-probe-extra-libraries-for-fdatasync.patchDownload+0-61
0002-Remove-traces-of-Sun-lposix4.patchtext/x-patch; charset=US-ASCII; name=0002-Remove-traces-of-Sun-lposix4.patchDownload+3-5
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Thomas Munro (#1)
Re: Minor configure/meson cleanup

On 07.08.23 11:18, Thomas Munro wrote:

0001: There is no point in searching -lrt and -lposix4 for fdatasync()
if it's supposed to help Solaris only. They moved all the realtime
stuff into the main C library at least as far back as Solaris
10/OpenSolaris.

0002: There is no point in probing -lposix4 for anything. That was
superseded by -lrt even longer ago.

We could go further: I suspect the only remaining -lrt search we
still need in practice is for shm_open() on glibc < 2.34, but here I
just wanted to clean out some old Sun stuff that was called out by
name.

Looks sensible to me.

#3Tristan Partin
tristan@neon.tech
In reply to: Thomas Munro (#1)
Re: Minor configure/meson cleanup

I agree that the change look good.

--
Tristan Partin
Neon (https://neon.tech)

#4Thomas Munro
thomas.munro@gmail.com
In reply to: Tristan Partin (#3)
Re: Minor configure/meson cleanup

On Tue, Aug 8, 2023 at 12:27 AM Tristan Partin <tristan@neon.tech> wrote:

I agree that the change look good.

Thanks both. Pushed.