Fix an entry in wait_event_names.txt

Started by Drouvot, Bertrandover 2 years ago3 messages
#1Drouvot, Bertrand
bertranddrouvot.pg@gmail.com
1 attachment(s)

Hi hackers,

While working on [1]/messages/by-id/735fbd560ae914c96faaa23cc8d9a118@oss.nttdata.com it has been noticed by Masahiro-san that the description field
in the new pg_wait_event view contains 2 blanks for one row.

It turns out that it comes from wait_event_names.txt (added in fa88928).

Attached a tiny patch to fix this entry in wait_event_names.txt (I did check that no
other entries are in the same case).

[1]: /messages/by-id/735fbd560ae914c96faaa23cc8d9a118@oss.nttdata.com

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachments:

v1-0001-Fix-incorrect-entry-in-wait_event_names.txt.patchtext/plain; charset=UTF-8; name=v1-0001-Fix-incorrect-entry-in-wait_event_names.txt.patchDownload
From 8ed089064bc92f0e721ecff93fdb40cbb25c310e Mon Sep 17 00:00:00 2001
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Date: Thu, 17 Aug 2023 04:04:44 +0000
Subject: [PATCH v1] Fix incorrect entry in wait_event_names.txt

fa88928 has introduced wait_event_names.txt, and one of its entries had
some documentation fields with two blanks.
---
 src/backend/utils/activity/wait_event_names.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/wait_event_names.txt b/src/backend/utils/activity/wait_event_names.txt
index f9e01e33b1..4d74f0068e 100644
--- a/src/backend/utils/activity/wait_event_names.txt
+++ b/src/backend/utils/activity/wait_event_names.txt
@@ -332,7 +332,7 @@ WAIT_EVENT_DOCONLY	ReplicationOriginState	"Waiting to read or update the progres
 WAIT_EVENT_DOCONLY	ReplicationSlotIO	"Waiting for I/O on a replication slot."
 WAIT_EVENT_DOCONLY	LockFastPath	"Waiting to read or update a process' fast-path lock information."
 WAIT_EVENT_DOCONLY	BufferMapping	"Waiting to associate a data block with a buffer in the buffer pool."
-WAIT_EVENT_DOCONLY	LockManager	"Waiting to read or update information  about <quote>heavyweight</quote> locks."
+WAIT_EVENT_DOCONLY	LockManager	"Waiting to read or update information about <quote>heavyweight</quote> locks."
 WAIT_EVENT_DOCONLY	PredicateLockManager	"Waiting to access predicate lock information used by serializable transactions."
 WAIT_EVENT_DOCONLY	ParallelHashJoin	"Waiting to synchronize workers during Parallel Hash Join plan execution."
 WAIT_EVENT_DOCONLY	ParallelQueryDSA	"Waiting for parallel query dynamic shared memory allocation."
-- 
2.34.1

#2Masahiro Ikeda
ikedamsh@oss.nttdata.com
In reply to: Drouvot, Bertrand (#1)
Re: Fix an entry in wait_event_names.txt

On 2023-08-17 14:49, Drouvot, Bertrand wrote:

Hi hackers,

While working on [1] it has been noticed by Masahiro-san that the
description field
in the new pg_wait_event view contains 2 blanks for one row.

It turns out that it comes from wait_event_names.txt (added in
fa88928).

Attached a tiny patch to fix this entry in wait_event_names.txt (I did
check that no
other entries are in the same case).

[1]:
/messages/by-id/735fbd560ae914c96faaa23cc8d9a118@oss.nttdata.com

Regards,

+1. Thanks!

Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION

#3Michael Paquier
michael@paquier.xyz
In reply to: Masahiro Ikeda (#2)
Re: Fix an entry in wait_event_names.txt

On Thu, Aug 17, 2023 at 03:25:27PM +0900, Masahiro Ikeda wrote:

+1. Thanks!

Applied.
--
Michael