Remove unnecessary 'always:' from CompilerWarnings task

On 05.09.23 12:25, Nazir Bilal Yavuz wrote:

There are multiple 'always:' keywords under the CompilerWarnings task.
Instead of that, we can use one 'always:' and move the instructions
under this. So, I removed unnecessary ones and rearranged indents
according to that change.

I'm not sure this change is beneficial. The way the code is currently
arranged, it's a bit easier to move or change individual blocks, and
it's also easier to read the file, because the "always:" is next to each
"script" and doesn't scroll off the screen.

Hi,

Thanks for the review.

On Wed, 8 Nov 2023 at 10:31, Peter Eisentraut <peter@eisentraut.org> wrote:

On 05.09.23 12:25, Nazir Bilal Yavuz wrote:

There are multiple 'always:' keywords under the CompilerWarnings task.
Instead of that, we can use one 'always:' and move the instructions
under this. So, I removed unnecessary ones and rearranged indents
according to that change.

I'm not sure this change is beneficial. The way the code is currently
arranged, it's a bit easier to move or change individual blocks, and
it's also easier to read the file, because the "always:" is next to each
"script" and doesn't scroll off the screen.

That makes sense. I am planning to withdraw this soon if there are no
other objections.

Regards,
Nazir Bilal Yavuz
Microsoft