Remove unnecessary 'always:' from CompilerWarnings task
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t48408psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 12:11 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t48408_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t48408_1 && git checkout t48408_1Patchset v1 (message #1) is on t48408_1
Hi,
There are multiple 'always:' keywords under the CompilerWarnings task.
Instead of that, we can use one 'always:' and move the instructions
under this. So, I removed unnecessary ones and rearranged indents
according to that change.
Any kind of feedback would be appreciated.
Regards,
Nazir Bilal Yavuz
Microsoft
On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
There are multiple 'always:' keywords under the CompilerWarnings task.
Instead of that, we can use one 'always:' and move the instructions
under this. So, I removed unnecessary ones and rearranged indents
according to that change.
I'm not sure this change is beneficial. The way the code is currently
arranged, it's a bit easier to move or change individual blocks, and
it's also easier to read the file, because the "always:" is next to each
"script" and doesn't scroll off the screen.
Hi,
Thanks for the review.
On Wed, 8 Nov 2023 at 10:31, Peter Eisentraut <peter@eisentraut.org> wrote:
On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
There are multiple 'always:' keywords under the CompilerWarnings task.
Instead of that, we can use one 'always:' and move the instructions
under this. So, I removed unnecessary ones and rearranged indents
according to that change.I'm not sure this change is beneficial. The way the code is currently
arranged, it's a bit easier to move or change individual blocks, and
it's also easier to read the file, because the "always:" is next to each
"script" and doesn't scroll off the screen.
That makes sense. I am planning to withdraw this soon if there are no
other objections.
Regards,
Nazir Bilal Yavuz
Microsoft