[Regression] Incorrect filename in test case comment
Hi,
While browsing the test cases, found that the incorrect filename was there
in the test case comment.
The below commit added the custom hash opclass in insert.sql,
--------------------------------------------------------------
*commit fafec4cce814b9b15991b62520dc5e5e84655a8aAuthor: Alvaro Herrera
<alvherre@alvh.no-ip.org <alvherre@alvh.no-ip.org>>Date: Fri Apr 13
12:27:22 2018 -0300 Use custom hash opclass for hash partition pruning*
--------------------------------------------------------------
and later below commit moved those to test_setup.sql
--------------------------------------------------------------
*commit cc50080a828dd4791b43539f5a0f976e535d147cAuthor: Tom Lane
<tgl@sss.pgh.pa.us <tgl@sss.pgh.pa.us>>Date: Tue Feb 8 15:30:38 2022
-0500*
* Rearrange core regression tests to reduce cross-script dependencies. *
--------------------------------------------------------------
but we haven't changed the filename in other test cases.
Did the same in the attached patch.
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
Attachments:
Fix_file_name_in_test_case.patchapplication/octet-stream; name=Fix_file_name_in_test_case.patchDownload
diff --git a/src/test/regress/expected/alter_table.out b/src/test/regress/expected/alter_table.out
index bfb1434..7666c76 100644
--- a/src/test/regress/expected/alter_table.out
+++ b/src/test/regress/expected/alter_table.out
@@ -4209,7 +4209,7 @@ CREATE TABLE quuux2 PARTITION OF quuux FOR VALUES IN (2);
DROP TABLE quuux;
-- check validation when attaching hash partitions
-- Use hand-rolled hash functions and operator class to get predictable result
--- on different machines. part_test_int4_ops is defined in insert.sql.
+-- on different machines. part_test_int4_ops is defined in test_setup.sql.
-- check that the new partition won't overlap with an existing partition
CREATE TABLE hash_parted (
a int,
diff --git a/src/test/regress/expected/hash_part.out b/src/test/regress/expected/hash_part.out
index ac3aabe..335fcc3 100644
--- a/src/test/regress/expected/hash_part.out
+++ b/src/test/regress/expected/hash_part.out
@@ -3,7 +3,7 @@
--
-- Use hand-rolled hash functions and operator classes to get predictable
-- result on different machines. See the definitions of
--- part_part_test_int4_ops and part_test_text_ops in insert.sql.
+-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.
CREATE TABLE mchash (a int, b text, c jsonb)
PARTITION BY HASH (a part_test_int4_ops, b part_test_text_ops);
CREATE TABLE mchash1
diff --git a/src/test/regress/expected/partition_prune.out b/src/test/regress/expected/partition_prune.out
index 1eb3475..8626561 100644
--- a/src/test/regress/expected/partition_prune.out
+++ b/src/test/regress/expected/partition_prune.out
@@ -1741,7 +1741,7 @@ drop table lp, coll_pruning, rlp, mc3p, mc2p, boolpart, iboolpart, boolrangep, r
--
-- Use hand-rolled hash functions and operator classes to get predictable
-- result on different machines. See the definitions of
--- part_part_test_int4_ops and part_test_text_ops in insert.sql.
+-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.
--
create table hp (a int, b text, c int)
partition by hash (a part_test_int4_ops, b part_test_text_ops);
diff --git a/src/test/regress/sql/alter_table.sql b/src/test/regress/sql/alter_table.sql
index eb8c334..9df5a63 100644
--- a/src/test/regress/sql/alter_table.sql
+++ b/src/test/regress/sql/alter_table.sql
@@ -2676,7 +2676,7 @@ DROP TABLE quuux;
-- check validation when attaching hash partitions
-- Use hand-rolled hash functions and operator class to get predictable result
--- on different machines. part_test_int4_ops is defined in insert.sql.
+-- on different machines. part_test_int4_ops is defined in test_setup.sql.
-- check that the new partition won't overlap with an existing partition
CREATE TABLE hash_parted (
diff --git a/src/test/regress/sql/hash_part.sql b/src/test/regress/sql/hash_part.sql
index e7eb365..ca9253a 100644
--- a/src/test/regress/sql/hash_part.sql
+++ b/src/test/regress/sql/hash_part.sql
@@ -4,7 +4,7 @@
-- Use hand-rolled hash functions and operator classes to get predictable
-- result on different machines. See the definitions of
--- part_part_test_int4_ops and part_test_text_ops in insert.sql.
+-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.
CREATE TABLE mchash (a int, b text, c jsonb)
PARTITION BY HASH (a part_test_int4_ops, b part_test_text_ops);
diff --git a/src/test/regress/sql/partition_prune.sql b/src/test/regress/sql/partition_prune.sql
index d1c60b8..fe6cc94 100644
--- a/src/test/regress/sql/partition_prune.sql
+++ b/src/test/regress/sql/partition_prune.sql
@@ -337,7 +337,7 @@ drop table lp, coll_pruning, rlp, mc3p, mc2p, boolpart, iboolpart, boolrangep, r
--
-- Use hand-rolled hash functions and operator classes to get predictable
-- result on different machines. See the definitions of
--- part_part_test_int4_ops and part_test_text_ops in insert.sql.
+-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.
--
create table hp (a int, b text, c int)
On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
While browsing the test cases, found that the incorrect filename was there
in the test case comment.
The below commit added the custom hash opclass in insert.sql,
--- part_part_test_int4_ops and part_test_text_ops in insert.sql.
+-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.Good catch, but part_part_test_int4_ops should be renamed to
part_test_int4_ops, removing the first "part_", no?
--
Michael
On 6 Sep 2023, at 07:18, Suraj Kharage <suraj.kharage@enterprisedb.com> wrote:
we haven't changed the filename in other test cases.
Did the same in the attached patch.
Pushed (along with a small typo fix), thanks!
--
Daniel Gustafsson
On 6 Sep 2023, at 10:19, Michael Paquier <michael@paquier.xyz> wrote:
On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
While browsing the test cases, found that the incorrect filename was there
in the test case comment.
The below commit added the custom hash opclass in insert.sql,--- part_part_test_int4_ops and part_test_text_ops in insert.sql. +-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.Good catch, but part_part_test_int4_ops should be renamed to
part_test_int4_ops, removing the first "part_", no?
Ah, seems we came to same conclusion when looking simultaneously, I just pushed
the fix with the typo fix.
--
Daniel Gustafsson
Thanks Daniel and Michael.
On Wed, Sep 6, 2023 at 1:52 PM Daniel Gustafsson <daniel@yesql.se> wrote:
On 6 Sep 2023, at 10:19, Michael Paquier <michael@paquier.xyz> wrote:
On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
While browsing the test cases, found that the incorrect filename was
there
in the test case comment.
The below commit added the custom hash opclass in insert.sql,--- part_part_test_int4_ops and part_test_text_ops in insert.sql. +-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.Good catch, but part_part_test_int4_ops should be renamed to
part_test_int4_ops, removing the first "part_", no?Ah, seems we came to same conclusion when looking simultaneously, I just
pushed
the fix with the typo fix.--
Daniel Gustafsson
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com