Add resource intensiveness as a reason to not running tests by default
Hi,
With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking'
as default because it is resource intensive; but regress docs doesn't
state resource intensiveness as a reason for not running tests by
default. So, I created a patch for updating the docs.
Any kind of feedback would be appreciated.
Regards,
Nazir Bilal Yavuz
Microsoft
Attachments:
v1-0001-Update-the-reasons-of-tests-not-running-by-defaul.patchtext/x-diff; charset=US-ASCII; name=v1-0001-Update-the-reasons-of-tests-not-running-by-defaul.patchDownload
From 847a06a3a0546a14f07654ff79da4039c5c7cc34 Mon Sep 17 00:00:00 2001
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Thu, 7 Sep 2023 13:33:46 +0300
Subject: [PATCH v1] Update the reasons of tests not running by default on docs
With f47ed79cc8, test suite doesn't run 'wal_consistency_checking' as
default because it is resource intensive. However, regress
documentation only states 'not secure to run on a multiuser system'
or 'requiring special software' as a reason to not run the tests
by default. Therefore, update the docs by adding 'resource intensive'
as a reason to not run tests by default.
---
doc/src/sgml/regress.sgml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/src/sgml/regress.sgml b/doc/src/sgml/regress.sgml
index de065c0564a..69f627d7f43 100644
--- a/doc/src/sgml/regress.sgml
+++ b/doc/src/sgml/regress.sgml
@@ -253,11 +253,11 @@ make check-world -j8 >/dev/null
<para>
Some test suites are not run by default, either because they are not secure
- to run on a multiuser system or because they require special software. You
- can decide which test suites to run additionally by setting the
- <command>make</command> or environment variable
- <varname>PG_TEST_EXTRA</varname> to a whitespace-separated list, for
- example:
+ to run on a multiuser system, because they require special software or
+ because they are resource intensive. You can decide which test suites to
+ run additionally by setting the <command>make</command> or environment
+ variable <varname>PG_TEST_EXTRA</varname> to a whitespace-separated list,
+ for example:
<programlisting>
make check-world PG_TEST_EXTRA='kerberos ldap ssl load_balance'
</programlisting>
--
2.40.1
On 7 Sep 2023, at 13:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking'
as default because it is resource intensive; but regress docs doesn't
state resource intensiveness as a reason for not running tests by
default. So, I created a patch for updating the docs.
Agreed, the current wording lacks the mention of skipping tests due to high
resource usage. Patch looks good from a quick skim, I'll backpatch it down to
15 which is where PG_TEST_EXTRA was first used in this capacity.
--
Daniel Gustafsson
On 7 Sep 2023, at 13:24, Daniel Gustafsson <daniel@yesql.se> wrote:
On 7 Sep 2023, at 13:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking'
as default because it is resource intensive; but regress docs doesn't
state resource intensiveness as a reason for not running tests by
default. So, I created a patch for updating the docs.Agreed, the current wording lacks the mention of skipping tests due to high
resource usage. Patch looks good from a quick skim, I'll backpatch it down to
15 which is where PG_TEST_EXTRA was first used in this capacity.
Pushed and backpatched, thanks!
--
Daniel Gustafsson