subscription TAP test has unused $result
Yesterday noticed a TAP test assignment to an unused $result.
PSA patch to remove that.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachments:
v1-0001-remove-redundant-result-assignment.patchapplication/octet-stream; name=v1-0001-remove-redundant-result-assignment.patchDownload
From 099d0b8ce614cbc6f28e9e1ae8ec8b1bff47bae3 Mon Sep 17 00:00:00 2001
From: Peter Smith <peter.b.smith@fujitsu.com>
Date: Wed, 13 Sep 2023 11:36:35 +1000
Subject: [PATCH v1] remove redundant result assignment
---
src/test/subscription/t/004_sync.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/subscription/t/004_sync.pl b/src/test/subscription/t/004_sync.pl
index aa7714c..bf4d59e 100644
--- a/src/test/subscription/t/004_sync.pl
+++ b/src/test/subscription/t/004_sync.pl
@@ -156,7 +156,7 @@ $node_subscriber->safe_psql('postgres',
"CREATE SUBSCRIPTION tap_sub CONNECTION '$publisher_connstr' PUBLICATION tap_pub"
);
-$result = $node_subscriber->poll_query_until('postgres', $started_query)
+$node_subscriber->poll_query_until('postgres', $started_query)
or die "Timed out while waiting for subscriber to start sync";
# DROP SUBSCRIPTION must clean up slots on the publisher side when the
--
1.8.3.1
On Wed, Sep 13, 2023 at 8:43 AM Peter Smith <smithpb2250@gmail.com> wrote:
Yesterday noticed a TAP test assignment to an unused $result.
PSA patch to remove that.
Though it is harmless I think we can clean it up. Your patch looks good to me.
--
With Regards,
Amit Kapila.
On Wed, Sep 13, 2023 at 10:14 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Wed, Sep 13, 2023 at 8:43 AM Peter Smith <smithpb2250@gmail.com> wrote:
Yesterday noticed a TAP test assignment to an unused $result.
PSA patch to remove that.
Though it is harmless I think we can clean it up. Your patch looks good to me.
Pushed.
--
With Regards,
Amit Kapila.