Sep 2023

3 commits
Improve error message for snapshot import in snapmgr.c, take two
19 Sep 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #122 of 3 reviewers saw the final version

The diff matches #12 exactly after excluding index-hash lengths, including the ENOENT branch in src/backend/utils/time/snapmgr.c and both regression tests. The commit explicitly credits Bharath Rupireddy as author although Michael Paquier submitted the final attachment.

  • Andres Freundsaw the final versiontrailerAndres challenged the original behavior in #7 and #8, then specified the final missing-snapshot wording and SQLSTATE in #11, which #12 implements directly.
  • Daniel Gustafssonsaw an earlier versiontrailerDaniel endorsed reuse of the generic diagnostic for translation consistency in #5, before the ENOENT branch and SQLSTATE changes in #10 and #12.
  • Michael Paquiersaw the final versiontrailerMichael endorsed the initial patch in #2, supplied the revised implementations in #10 and #12, and committed the final version.
Revert "Improve error message on snapshot import in snapmgr.c"
14 Sep 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.1REL_15_STABLE15.5REL_14_STABLE14.10REL_13_STABLE13.13+2 morereverts 1 commit here
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

The diff exactly reverses a0d87bcd9b, restoring the original diagnostic and SQLSTATE in src/backend/utils/time/snapmgr.c. Andres requested the revert in #8, and Michael confirmed it in #10; no attached patchset supplies the revert.

  • Andres Freundsaw an earlier versionLLM analysis, 96% sureBefore the revert, Andres identified the compatibility-breaking SQLSTATE change and requested reversal in #8; his qualifying review concerns #1, before the substantive revisions leading to the thread's final patchset.
Improve error message on snapshot import in snapmgr.c
14 Sep 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.1REL_15_STABLE15.5REL_14_STABLE14.10REL_13_STABLE13.13+2 more
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The single-hunk change in src/backend/utils/time/snapmgr.c matches #1 exactly after excluding index-hash lengths and the email footer. Michael confirmed application and backpatching in #6.

  • Daniel Gustafssonsaw the final versiontrailerDaniel endorsed the generic error message in #5, noting that reusing an existing diagnostic reduces translation work, and that patch landed unchanged.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Bharath Rupireddy2
Reviewer
Daniel Gustafsson2
Michael Paquiercommitter2
Andres Freund1
Committer
Michael Paquier3