Re: CVS broken?

Started by Hiroshi Inoueover 25 years ago4 messages
#1Hiroshi Inoue
Inoue@tpf.co.jp

Philip Warner wrote:

I get the following when I build from CVS:

gcc -I../../../src/include -I../../../src/interfaces/libpq -O2 -g -Wall
-Wmissing-prototypes -Wmissing-declarations -o pg_dump pg_dump.o common.o
pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o
pg_backup_null.o pg_backup_tar.o -L../../..
/src/interfaces/libpq -lpq -lz -lcrypt -lnsl -ldl -lm -lreadline -lncurses
-lz
../../../src/interfaces/libpq/libpq.so: undefined reference to
`FailedAssertion'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`assert_enabled'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`ExceptionalCondition'

Does anyone else have this problem?

I have already encountered the problem.
-DFRONTEND isn't set in the above command line.

For example the following line
CFLAGS+= -DFRONTEND -I$(srcdir)
in makefiles doesn't work currently.

I found the recent change in Makefile.global.in.
ifeq ($(GCC), yes)
override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
endif

Do we have to override CFLAGS every time ?

Regards.

Hiroshi Inoue

#2Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Hiroshi Inoue (#1)

-Wmissing-prototypes -Wmissing-declarations -o pg_dump pg_dump.o common.o
pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o
pg_backup_null.o pg_backup_tar.o -L../../..
/src/interfaces/libpq -lpq -lz -lcrypt -lnsl -ldl -lm -lreadline -lncurses
-lz
../../../src/interfaces/libpq/libpq.so: undefined reference to
`FailedAssertion'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`assert_enabled'
../../../src/interfaces/libpq/libpq.so: undefined reference to
`ExceptionalCondition'

Does anyone else have this problem?

I have already encountered the problem.
-DFRONTEND isn't set in the above command line.

For example the following line
CFLAGS+= -DFRONTEND -I$(srcdir)
in makefiles doesn't work currently.

I found the recent change in Makefile.global.in.
ifeq ($(GCC), yes)
override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
endif

OK, I have removed 'override' from CFLAGS, and committed. Seems like it
came in with:

date: 2000/10/08 21:13:27; author: petere; state: Exp; lines: +165 -137
Append "/postgresql" to (certain) installation subdirectories when
installing into a shared location. Also Makefile.global organizational
cleanup.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#3Peter Eisentraut
peter_e@gmx.net
In reply to: Hiroshi Inoue (#1)

Hiroshi Inoue writes:

For example the following line
CFLAGS+= -DFRONTEND -I$(srcdir)
in makefiles doesn't work currently.

I found the recent change in Makefile.global.in.
ifeq ($(GCC), yes)
override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
endif

Seems like a problem in make. What versions are you using?

--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/

#4Hiroshi Inoue
Inoue@tpf.co.jp
In reply to: Peter Eisentraut (#3)

Peter Eisentraut wrote:

Hiroshi Inoue writes:

For example the following line
CFLAGS+= -DFRONTEND -I$(srcdir)
in makefiles doesn't work currently.

I found the recent change in Makefile.global.in.
ifeq ($(GCC), yes)
override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
endif

Seems like a problem in make. What versions are you using?

I tried the following makefile in cygwin and linux 2.0.36.

[makefile]
#
override CFLAGS += -DDEFINE1
CFLAGS += -DDEFINE2

all: a.o

[cygwin]
$ make -v
GNU Make version 3.79.1, by Richard Stallman and Roland McGrath.
Built for i686-pc-cygwin
Copyright (C) 1988, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 2000
Free Software Foundation, Inc.
...
$ make
gcc -DDEFINE1 -c -o a.o a.c
a.c:1: parse error before `{'
make: *** [a.o] Error 1

[linux]
$ make -v
GNU Make version 3.76.1, by Richard Stallman and Roland McGrath.
Copyright (C) 1988, 89, 90, 91, 92, 93, 94, 95, 96, 97
Free Software Foundation, Inc.
...
$ make
cc -DDEFINE1 -c a.c -o a.o
a.c:1: parse error before `{'
make: *** [a.o] Error 1

-DDEFINE2 is expanded in neither case.

Regards.

Hiroshi Inoue