Mar 2024

1 commit
meson: macos: Avoid warnings on Sonoma
13 Mar 2024Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #431 of 2 reviewers saw the final version

The development-branch commit contains exactly the meson.build warning fixes from #43; its .cirrus.tasks.yml and src/tools/ci/ci_macports_packages.sh testing changes were omitted.

  • Robert Haassaw an earlier versionLLM analysis, 83% sureRobert tested an inline removal of the undefined-error flag and measured the warning reduction in #40, before the final conditional compatibility check was introduced.
  • Tom Lanesaw the final versionLLM analysis, 80% sureTom endorsed the proposed duplicate-library suppression flag subject to availability in #42, which #43 addressed with a supported-argument check.

Sep - Oct 2023

4 commits
Restore proper linkage of pg_char_to_encoding() and friends.
7 Oct 2023Tom Lanemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #231 of 1 reviewer saw the final version

All five files implement #23, with only the initdb Meson argument construction simplified to pass c_args directly to executable(). Andres requested that adjustment in #24 and #26, and Tom confirmed applying it in #27.

  • Andres Freundsaw the final versionLLM analysis, 100% sureAndres endorsed the design and proposed the adopted c_args simplification in #24 and #26, and the commit message explicitly thanks him for review.
meson: macos: Correct -exported_symbols_list syntax for Sonoma compat
30 Sep 2023Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #111 of 1 reviewer saw the final version

This commits the first patch of #11 unchanged in meson.build, switching export_fmt to -Wl,-exported_symbols_list,@0@; the second patch proposing Sonoma CI was not included.

  • Tom Lanesaw the final versiontrailerTom tested the equivalent linker syntax on Catalina and verified correctly restricted shared-library exports in #12.
Suppress macOS warnings about duplicate libraries in link commands.
29 Sep 2023Tom Lanemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.1REL_15_STABLE15.5REL_14_STABLE14.10REL_13_STABLE13.13+2 more
LLM analysis, 100% surelanded as postedfrom patchset #160 of 1 reviewer saw the final version

The src/Makefile.global.in additions and removals exactly match #16, making libpq_pgport equivalent to libpq on every platform.

  • Andres Freundsaw an earlier versionLLM analysis, 94% sureAndres argued that supported platforms already had export control in #7, prompting broader platform behavior; his explicit approval in #17 came after the commit.
Stop using "-multiply_defined suppress" on macOS.
27 Sep 2023Tom Lanemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.1REL_15_STABLE15.5REL_14_STABLE14.10REL_13_STABLE13.13+2 more
LLM analysis, 100% surewritten from the discussion, no matching patch

Tom proposed and tested removing -multiply_defined suppress in #1 and #2; this commit removes it from both Darwin LINK.shared recipes in src/Makefile.shlib without an attached patchset.

Credits across 5 commits

Author
Andres FreundLLM2
Tom LaneLLM2
Reviewer
Tom Lane1
Committer
Tom Lane3
Andres Freund2

N LLM means N of the credits come from LLM analysis, not from commit trailers.